From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH kvm-unit-tests] x86: fix build (macro R interpreted as raw string) Date: Wed, 18 Mar 2015 19:53:49 -0300 Message-ID: <20150318225349.GB8702@amt.cnet> References: <1426265284-29107-1-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57700 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754862AbbCRWyD (ORCPT ); Wed, 18 Mar 2015 18:54:03 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2IMs2m0029469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 18 Mar 2015 18:54:02 -0400 Content-Disposition: inline In-Reply-To: <1426265284-29107-1-git-send-email-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Mar 13, 2015 at 05:48:04PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: > GCC 5.0.0 enables raw strings by default and they have higher priorit= y > than macros, thus R"[...]" is interpreted incorrectly: >=20 > lib/x86/isr.c:112:30: error: invalid character ')' in raw string de= limiter > lib/x86/isr.c:112:8: error: stray =E2=80=98R=E2=80=99 in program > lib/x86/isr.c:112:26: error: expected =E2=80=98:=E2=80=99 or =E2=80= =98)=E2=80=99 before string constant > "orl $0x200, (%%"R"sp)\n\t" >=20 > Fix it by putting a space between macro R and a string literal. > (We already do that somewhere.) >=20 > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 Applied, thanks.