From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: x86: call irq notifiers with directed EOI Date: Thu, 19 Mar 2015 20:42:54 +0100 Message-ID: <20150319194253.GA3584@potion.brq.redhat.com> References: <1426703902-16818-1-git-send-email-rkrcmar@redhat.com> <550B065F.6040603@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Marcelo Tosatti , chao.zhou@intel.com To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: <550B065F.6040603@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org 2015-03-19 18:24+0100, Paolo Bonzini: > > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > > @@ -833,8 +833,7 @@ int kvm_apic_compare_prio(struct kvm_vcpu *vcpu1, struct kvm_vcpu *vcpu2) > > - if (!(kvm_apic_get_reg(apic, APIC_SPIV) & APIC_SPIV_DIRECTED_EOI) && > > - kvm_ioapic_handles_vector(apic->vcpu->kvm, vector)) { > > + if (kvm_ioapic_handles_vector(apic->vcpu->kvm, vector)) { > > Can you look into making kvm_ioapic_handles_vector inline in ioapic.h? Will do. > Reviewed-by: Paolo Bonzini Thanks.