From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2 02/12] KVM: move iodev.h from virt/kvm/ to include/kvm Date: Wed, 25 Mar 2015 18:41:12 -0300 Message-ID: <20150325214112.GC3649@amt.cnet> References: <1427126309-11223-1-git-send-email-andre.przywara@arm.com> <1427126309-11223-3-git-send-email-andre.przywara@arm.com> <5512E992.1020800@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" , Andre Przywara , "linux-arm-kernel@lists.infradead.org" , "pbonzini@redhat.com" , "kvmarm@lists.cs.columbia.edu" To: Marc Zyngier Return-path: Content-Disposition: inline In-Reply-To: <5512E992.1020800@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On Wed, Mar 25, 2015 at 05:00:02PM +0000, Marc Zyngier wrote: > On 23/03/15 15:58, Andre Przywara wrote: > > iodev.h contains definitions for the kvm_io_bus framework. This is > > needed both by the generic KVM code in virt/kvm as well as by > > architecture specific code under arch/. Putting the header file in > > virt/kvm and using local includes in the architecture part seems at > > least dodgy to me, so let's move the file into include/kvm, so that a > > more natural "#include " can be used by all of the code. > > This also solves a problem later when using struct kvm_io_device > > in arm_vgic.h. > > Fixing up the FSF address in the GPL header and a wrong include path > > on the way. > > > > Signed-off-by: Andre Przywara > > Acked-by: Christoffer Dall > > Reviewed-by: Marc Zyngier > > Paolo, Marcelo: can we have your Ack on this? > > Thanks, Reviewed-by: Marcelo Tosatti