From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gavin Shan Subject: Re: [PATCH v4 4/4] drivers/vfio: Remove duplicated PE states Date: Thu, 26 Mar 2015 11:59:03 +1100 Message-ID: <20150326005903.GA16778@shangw> References: <1427325637-14345-1-git-send-email-gwshan@linux.vnet.ibm.com> <1427325637-14345-5-git-send-email-gwshan@linux.vnet.ibm.com> <1427330788.3643.883.camel@redhat.com> Reply-To: Gavin Shan Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gavin Shan , linuxppc-dev@ozlabs.org, kvm@vger.kernel.org, david@gibson.dropbear.id.au, agraf@suse.de To: Alex Williamson Return-path: Received: from e23smtp09.au.ibm.com ([202.81.31.142]:34451 "EHLO e23smtp09.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbbCZBAF (ORCPT ); Wed, 25 Mar 2015 21:00:05 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Mar 2015 11:00:03 +1000 Received: from d23relay10.au.ibm.com (d23relay10.au.ibm.com [9.190.26.77]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 15A972BB0052 for ; Thu, 26 Mar 2015 12:00:02 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2Q0xrxP48300050 for ; Thu, 26 Mar 2015 12:00:01 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2Q0xRqK020739 for ; Thu, 26 Mar 2015 11:59:28 +1100 Content-Disposition: inline In-Reply-To: <1427330788.3643.883.camel@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Mar 25, 2015 at 06:46:28PM -0600, Alex Williamson wrote: >On Thu, 2015-03-26 at 10:20 +1100, Gavin Shan wrote: >> The set of constants for PE states defined in uapi/linux/vfio.h is >> duplicated to uapi/asm/eeh.h. The patch removes the set from the >> former. >> >> Signed-off-by: Gavin Shan >> --- >> include/uapi/linux/vfio.h | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h >> index d81c17f..3fd1e86 100644 >> --- a/include/uapi/linux/vfio.h >> +++ b/include/uapi/linux/vfio.h >> @@ -492,11 +492,6 @@ struct vfio_eeh_pe_op { >> #define VFIO_EEH_PE_UNFREEZE_IO 2 /* Enable IO for frozen PE */ >> #define VFIO_EEH_PE_UNFREEZE_DMA 3 /* Enable DMA for frozen PE */ >> #define VFIO_EEH_PE_GET_STATE 4 /* PE state retrieval */ >> -#define VFIO_EEH_PE_STATE_NORMAL 0 /* PE in functional state */ >> -#define VFIO_EEH_PE_STATE_RESET 1 /* PE reset in progress */ >> -#define VFIO_EEH_PE_STATE_STOPPED 2 /* Stopped DMA and IO */ >> -#define VFIO_EEH_PE_STATE_STOPPED_DMA 4 /* Stopped DMA only */ >> -#define VFIO_EEH_PE_STATE_UNAVAIL 5 /* State unavailable */ >> #define VFIO_EEH_PE_RESET_DEACTIVATE 5 /* Deassert PE reset */ >> #define VFIO_EEH_PE_RESET_HOT 6 /* Assert hot reset */ >> #define VFIO_EEH_PE_RESET_FUNDAMENTAL 7 /* Assert fundamental reset */ > >How do you know that nobody depends on these defines? I thought the >suggestion was to use the EEH_* defines for error injection, not to >remove existing VFIO_EEH_* defines. You could certainly redefine these >in terms of EEH_* defines instead. Thanks, > QEMU should be the first user to utilize the EEH capability exposed by the host kernel, and I believe QEMU doesn't use those constants yet. So it's right time to move those constants to uapi/asm/eeh.h. Once some one starts to use them, it's impossible to do so. Thanks, Gavin >Alex >