From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: XP machine freeze
Date: Mon, 13 Apr 2015 15:33:56 +0200
Message-ID: <20150413133356.GB23280@potion.brq.redhat.com>
References: <009701d05ffb$5e37a740$1aa6f5c0$@astim.si>
 <550EE047.3030605@fnarfbargle.com>
 <5519BBF4.7080600@redhat.com>
 <552B40F7.5080107@fnarfbargle.com>
 <552BB8D5.7060200@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Brad Campbell <lists2009@fnarfbargle.com>,
	Saso Slavicic <saso.linux@astim.si>, kvm@vger.kernel.org
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:59309 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752889AbbDMNeD (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 13 Apr 2015 09:34:03 -0400
Content-Disposition: inline
In-Reply-To: <552BB8D5.7060200@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2015-04-13 14:38+0200, Paolo Bonzini:
> If so, the most likely culprit is this:
> 
> commit 6addfc42992be4b073c39137ecfdf4b2aa2d487f
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date:   Thu Mar 27 11:29:28 2014 +0100
> 
>     KVM: x86: avoid useless set of KVM_REQ_EVENT after emulation
| [...]
> 
> I would first try this one, and see if it is bad.
> 
> Radim, do you think this could cause a missed interrupt injection
> after Windows does a TPR write?

I don't think it could, all changes to TPR/ISR should call
apic_update_ppr, which sets KVM_REQ_EVENT when needed ...

I'll take a look what could have gone wrong.