public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Hans J. Koch" <hjk@hansjkoch.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uio: add irq control support to uio_pci_generic
Date: Thu, 16 Apr 2015 14:21:10 -0700	[thread overview]
Message-ID: <20150416142110.2fc80b15@urahara> (raw)
In-Reply-To: <20150416094105-mutt-send-email-mst@redhat.com>

On Thu, 16 Apr 2015 09:43:24 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Wed, Apr 15, 2015 at 09:59:34AM -0700, Stephen Hemminger wrote:
> > The driver already supported INTX interrupts but had no in kernel
> > function to enable and disable them.
> > 
> > It is possible for userspace to do this by accessing PCI config
> > directly, but this racy
> 
> How is it racy? We have userspace using this interface,
> if there's a race I want to fix it.

There is nothing to prevent two threads in user space doing 
read/modify write at the same time.

The bigger issue is that DPDK needs to support multiple UIO
interface types. And with current model there is no abstraction.
The way to enable/disable IRQ is different depending on the UIO
drivers.

  reply	other threads:[~2015-04-16 21:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 16:59 [PATCH] uio: add irq control support to uio_pci_generic Stephen Hemminger
2015-04-16  7:43 ` Michael S. Tsirkin
2015-04-16 21:21   ` Stephen Hemminger [this message]
2015-04-20 13:59     ` Michael S. Tsirkin
2015-04-20 15:33       ` Stephen Hemminger
2015-04-20 15:40         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150416142110.2fc80b15@urahara \
    --to=stephen@networkplumber.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hjk@hansjkoch.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox