public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Serebrin <serebrin@google.com>
Cc: kvm@vger.kernel.org, stable@vger.kernel.org, luto@amacapital.net,
	pbonzini@redhat.com, jankiszka@siemens.com
Subject: Re: [PATCH] KVM: VMX: Preserve host CR4.MCE value while in guest mode.
Date: Fri, 17 Apr 2015 10:55:39 +0200	[thread overview]
Message-ID: <20150417085539.GA22515@kroah.com> (raw)
In-Reply-To: <1429210685-19510-1-git-send-email-serebrin@google.com>

On Thu, Apr 16, 2015 at 11:58:05AM -0700, Ben Serebrin wrote:
> The host's decision to enable machine check exceptions should remain
> in force during non-root mode.  KVM was writing 0 to cr4 on VCPU reset
> and passed a slightly-modified 0 to the vmcs.guest_cr4 value.
> 
> Tested: Built.
> On earlier version, tested by injecting machine check
> while a guest is spinning.
> 
> Before the change, if guest CR4.MCE==0, then the machine check is
> escalated to Catastrophic Error (CATERR) and the machine dies.
> If guest CR4.MCE==1, then the machine check causes VMEXIT and is
> handled normally by host Linux. After the change, injecting a machine
> check causes normal Linux machine check handling.
> 
> Signed-off-by: Ben Serebrin <serebrin@google.com>
> ---
>  arch/x86/kvm/vmx.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

  parent reply	other threads:[~2015-04-17  8:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16 18:58 [PATCH] KVM: VMX: Preserve host CR4.MCE value while in guest mode Ben Serebrin
2015-04-16 20:42 ` Venkatesh Srinivas
2015-04-17  5:10 ` Wanpeng Li
2015-04-17 10:16   ` Paolo Bonzini
2015-04-17 16:03     ` Benjamin Serebrin
2015-04-19 22:59     ` Wanpeng Li
2015-04-17  8:55 ` Greg KH [this message]
2015-04-17 10:10   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150417085539.GA22515@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jankiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=pbonzini@redhat.com \
    --cc=serebrin@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox