public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Wei Huang <wei@redhat.com>
Cc: kvm@vger.kernel.org, gleb@kernel.org, pbonzini@redhat.com,
	joro@8bytes.org
Subject: Re: [PATCH V3 0/4] KVM vPMU support for AMD CPUs
Date: Tue, 21 Apr 2015 18:38:01 +0200	[thread overview]
Message-ID: <20150421163800.GC15969@potion.brq.redhat.com> (raw)
In-Reply-To: <1429338232-11938-1-git-send-email-wei@redhat.com>

2015-04-18 02:23-0400, Wei Huang:
> Currently KVM only supports vPMU for Intel CPUs. This patchset enables
> KVM vPMU support for AMD platform by creating a common PMU interface for
> x86. By refractoring, PMU related MSR accesses from guest VMs are dispatched
> to corresponding functions defined in arch specific files.
> 
> V3:
>   * Rebase the code to the latest of KVM tree (queue branch);
>   * Branch out the Intel specific code from pmu.c to pmu_intel.c, in order
>     to reflect the change history more accurately;
>   * Name the parameters/variables more consistently (use msr, idx, 
>     pmc_idx) across files;
>   * Fix issues (whitespaces, macro names, ...) based on Radim's V2 comments;
>   * Fix the MSR_K7_PERFCTRn and MSR_K7_EVNTSELn access code (in patch 4);

Looks ok, thanks.  I only have petty comments about naming and stuff and
ideas leading to less code duplication ... I'll just smoke test it and
give the proper tag tomorrow.

  parent reply	other threads:[~2015-04-21 16:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-18  6:23 [PATCH V3 0/4] KVM vPMU support for AMD CPUs Wei Huang
2015-04-18  6:23 ` [PATCH V3 1/4] KVM: x86/vPMU: Define kvm_pmu_ops to support vPMU function dispatch Wei Huang
2015-04-18  6:23 ` [PATCH V3 2/4] KVM: x86/vPMU: Create vPMU interface for VMX and SVM Wei Huang
2015-04-22 17:20   ` Radim Krčmář
2015-04-18  6:23 ` [PATCH V3 3/4] KVM: x86/vPMU: Implement AMD vPMU code for KVM Wei Huang
2015-04-22 17:22   ` Radim Krčmář
2015-04-18  6:23 ` [PATCH V3 4/4] KVM: x86/vPMU: Enable PMU handling for AMD PERFCTRn and EVNTSELn MSRs Wei Huang
2015-04-22 17:23   ` Radim Krčmář
2015-04-21 16:38 ` Radim Krčmář [this message]
2015-04-22 17:28 ` [PATCH V3 0/4] KVM vPMU support for AMD CPUs Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150421163800.GC15969@potion.brq.redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=gleb@kernel.org \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox