Re: [PATCH V3 0/4] KVM vPMU support for AMD CPUs

["Radim Krčmář" <rkrcmar@redhat.com>]

2015-04-18 02:23-0400, Wei Huang:
> Currently KVM only supports vPMU for Intel CPUs. This patchset enables
> KVM vPMU support for AMD platform by creating a common PMU interface for
> x86. By refractoring, PMU related MSR accesses from guest VMs are dispatched
> to corresponding functions defined in arch specific files.
> 
> V3:
>   * Rebase the code to the latest of KVM tree (queue branch);
>   * Branch out the Intel specific code from pmu.c to pmu_intel.c, in order
>     to reflect the change history more accurately;
>   * Name the parameters/variables more consistently (use msr, idx, 
>     pmc_idx) across files;
>   * Fix issues (whitespaces, macro names, ...) based on Radim's V2 comments;
>   * Fix the MSR_K7_PERFCTRn and MSR_K7_EVNTSELn access code (in patch 4);

I still wasn't happy about the API, especially naming, but didnt't find
any bugs in functionality, also

Tested-by: Radim Krčmář <rkrcmar@redhat.com>

I didn't give reviewed-by to all patches, but if we want it fast,
there's no problem in fixing some stuff later.  (Though it usually
doesn't happen and we end up with bad code.)