From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH V3 0/4] KVM vPMU support for AMD CPUs Date: Wed, 22 Apr 2015 19:28:51 +0200 Message-ID: <20150422172850.GD6838@potion.brq.redhat.com> References: <1429338232-11938-1-git-send-email-wei@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, gleb@kernel.org, pbonzini@redhat.com, joro@8bytes.org To: Wei Huang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42057 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965022AbbDVR26 (ORCPT ); Wed, 22 Apr 2015 13:28:58 -0400 Content-Disposition: inline In-Reply-To: <1429338232-11938-1-git-send-email-wei@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2015-04-18 02:23-0400, Wei Huang: > Currently KVM only supports vPMU for Intel CPUs. This patchset enable= s > KVM vPMU support for AMD platform by creating a common PMU interface = for > x86. By refractoring, PMU related MSR accesses from guest VMs are dis= patched > to corresponding functions defined in arch specific files. >=20 > V3: > * Rebase the code to the latest of KVM tree (queue branch); > * Branch out the Intel specific code from pmu.c to pmu_intel.c, in = order > to reflect the change history more accurately; > * Name the parameters/variables more consistently (use msr, idx,=20 > pmc_idx) across files; > * Fix issues (whitespaces, macro names, ...) based on Radim's V2 co= mments; > * Fix the MSR_K7_PERFCTRn and MSR_K7_EVNTSELn access code (in patch= 4); I still wasn't happy about the API, especially naming, but didnt't find any bugs in functionality, also Tested-by: Radim Kr=C4=8Dm=C3=A1=C5=99 I didn't give reviewed-by to all patches, but if we want it fast, there's no problem in fixing some stuff later. (Though it usually doesn't happen and we end up with bad code.)