From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
gleb@kernel.org, kvm@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
luto@kernel.org
Subject: Re: [GIT PULL] First batch of KVM changes for 4.1
Date: Wed, 22 Apr 2015 17:56:02 -0300 [thread overview]
Message-ID: <20150422205602.GA15317@amt.cnet> (raw)
In-Reply-To: <55353058.2000008@redhat.com>
On Mon, Apr 20, 2015 at 06:59:04PM +0200, Paolo Bonzini wrote:
>
>
> On 17/04/2015 22:18, Marcelo Tosatti wrote:
> > The bug which this is fixing is very rare, have no memory of a report.
> >
> > In fact, its even difficult to create a synthetic reproducer.
>
> But then why was the task migration notifier even in Jeremy's original
> code for Xen?
To cover for the vcpu1 -> vcpu2 -> vcpu1 case, i believe.
> Was it supposed to work even on non-synchronized TSC?
Yes it is supposed to work on non-synchronized TSC.
> If that's the case, then it could be reverted indeed; but then why did
> you commit this patch to 4.1?
Because it fixes the problem Andy reported (see Subject: KVM: x86: fix
kvmclock write race (v2) on kvm@). As long as you have Radim's
fix on top.
> Did you think of something that would
> cause the seqcount-like protocol to fail, and that turned out not to be
> the case later? I was only following the mailing list sparsely in March.
No.
next prev parent reply other threads:[~2015-04-22 20:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 15:01 [GIT PULL] First batch of KVM changes for 4.1 Paolo Bonzini
2015-04-17 8:52 ` Peter Zijlstra
2015-04-17 9:17 ` Peter Zijlstra
2015-04-17 10:09 ` Paolo Bonzini
2015-04-17 10:36 ` Peter Zijlstra
2015-04-17 10:38 ` Paolo Bonzini
2015-04-17 10:55 ` Peter Zijlstra
2015-04-17 12:46 ` Paolo Bonzini
2015-04-17 13:10 ` Peter Zijlstra
2015-04-17 13:38 ` Paolo Bonzini
2015-04-17 13:43 ` Peter Zijlstra
2015-04-17 14:57 ` Paolo Bonzini
2015-04-17 19:01 ` Marcelo Tosatti
2015-04-17 19:16 ` Andy Lutomirski
2015-04-17 19:57 ` Paolo Bonzini
2015-04-17 20:18 ` Marcelo Tosatti
2015-04-17 20:39 ` Andy Lutomirski
2015-04-17 21:28 ` Linus Torvalds
2015-04-17 21:42 ` Andy Lutomirski
2015-04-17 22:04 ` Linus Torvalds
2015-04-17 22:25 ` Andy Lutomirski
2015-04-17 23:39 ` Marcelo Tosatti
2015-04-18 16:20 ` Paolo Bonzini
2015-04-20 16:59 ` Paolo Bonzini
2015-04-20 20:27 ` Andy Lutomirski
2015-04-22 21:21 ` Marcelo Tosatti
2015-04-23 9:13 ` Paolo Bonzini
2015-04-23 11:51 ` Marcelo Tosatti
2015-04-23 12:02 ` Paolo Bonzini
2015-04-23 17:06 ` Marcelo Tosatti
2015-04-22 20:56 ` Marcelo Tosatti [this message]
2015-04-22 21:01 ` Paolo Bonzini
2015-04-22 22:55 ` Marcelo Tosatti
2015-04-23 11:29 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422205602.GA15317@amt.cnet \
--to=mtosatti@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox