From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [GIT PULL] First batch of KVM changes for 4.1
Date: Thu, 23 Apr 2015 14:06:17 -0300
Message-ID: <20150423170617.GC7482@amt.cnet>
References: <55310CF2.6070107@redhat.com>
 <20150417190146.GA24395@amt.cnet>
 <55316598.908@redhat.com>
 <20150417201841.GA31302@amt.cnet>
 <55353058.2000008@redhat.com>
 <CALCETrW15jX9eh3fqJNzoeD6yveov6rr9NkOLqCe6fJCK_LXoA@mail.gmail.com>
 <20150422212148.GA17494@amt.cnet>
 <5538B7B3.2020009@redhat.com>
 <20150423115117.GA32371@amt.cnet>
 <5538DF55.30709@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andy Lutomirski <luto@amacapital.net>,
	Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Gleb Natapov <gleb@kernel.org>, kvm list <kvm@vger.kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	Andrew Lutomirski <luto@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:34139 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1030272AbbDWRHK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 23 Apr 2015 13:07:10 -0400
Content-Disposition: inline
In-Reply-To: <5538DF55.30709@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Apr 23, 2015 at 02:02:29PM +0200, Paolo Bonzini wrote:
> 
> 
> On 23/04/2015 13:51, Marcelo Tosatti wrote:
> >>> > > https://bugzilla.redhat.com/show_bug.cgi?id=1174664
> >> > 
> >> > That was the missing volatile in an asm.  Older compilers didn't catch
> >> > it. :(
> > How do you know that? It looks like memory corruption (look at the
> > pattern at the end).
> 
> I suspect some kind of operator error there, it makes no sense.


        if (unlikely(s->flags & SLAB_POISON))
                memset(start, POISON_INUSE, PAGE_SIZE << order);

 *      Padding is done using 0x5a (POISON_INUSE)

> On the other hand, bug 1178975 is much clearer and the symptoms are the
> same.  In that bug, you can see that the same kernel source works on f20
> (package version 3.17.7-200.fc20.x86_64) and fails on f21 (package
> version 3.17.7-300.fc21.x86_64).  Of course the compiler is different.
> The newer one hoists the lsl out of the loop; if you get a CPU migration
> at the wrong time, the cpu != cpu1 condition will always be true the
> loop will never exit.
> 
> Paolo