From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: x86: kvmclock: drop rdtsc_barrier() Date: Tue, 28 Apr 2015 22:47:38 -0300 Message-ID: <20150429014737.GA14997@amt.cnet> References: <20150425013614.GA12023@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andy Lutomirski , Rik van Riel To: kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44333 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031323AbbD2Br5 (ORCPT ); Tue, 28 Apr 2015 21:47:57 -0400 Content-Disposition: inline In-Reply-To: <20150425013614.GA12023@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Apr 24, 2015 at 10:36:14PM -0300, Marcelo Tosatti wrote: > > Drop unnecessary rdtsc_barrier(), as has been determined empirically, > see 057e6a8c660e95c3f4e7162e00e2fee1fc90c50d for details. > > Noticed by Andy Lutomirski. > > Improves clock_gettime() by approximately 15% on > Intel i7-3520M @ 2.90GHz. > > Signed-off-by: Marcelo Tosatti > > diff --git a/arch/x86/include/asm/pvclock.h b/arch/x86/include/asm/pvclock.h > index 25b1cc0..a5beb23 100644 > --- a/arch/x86/include/asm/pvclock.h > +++ b/arch/x86/include/asm/pvclock.h > @@ -86,7 +86,6 @@ unsigned __pvclock_read_cycles(const struct pvclock_vcpu_time_info *src, > offset = pvclock_get_nsec_offset(src); > ret = src->system_time + offset; > ret_flags = src->flags; > - rdtsc_barrier(); > > *cycles = ret; > *flags = ret_flags; > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Ping?