From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH] signals: Generate warning when flush_signals() is called from non-kthread context Date: Mon, 4 May 2015 19:35:16 +0200 Message-ID: <20150504173515.GA12200@redhat.com> References: <1430502057.4472.255.camel@redhat.com> <20150501193813.GA2812@gmail.com> <20150502183001.07eae212@notabene.brown> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ingo Molnar , Linus Torvalds , Evgeniy Polyakov , Stephen Smalley , Alex Williamson , linux-kernel , kvm To: NeilBrown Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44950 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbbEDRfm (ORCPT ); Mon, 4 May 2015 13:35:42 -0400 Content-Disposition: inline In-Reply-To: <20150502183001.07eae212@notabene.brown> Sender: kvm-owner@vger.kernel.org List-ID: On 05/02, NeilBrown wrote: > > All the calls in md.c are in a kernel thread so safe, but I'd rather have an > explicit "uninterruptible, but no load-average" wait.... Could you please explain why md_thread() does allow_signal(SIGKILL) ? I am just curious. It looks as if we want to allow user-space to "call" thread->run(), and this looks strange. Oleg.