From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v5 05/12] KVM: arm: introduce kvm_arm_init/setup/clear_debug Date: Thu, 4 Jun 2015 13:07:40 +0200 Message-ID: <20150604110740.GH7657@cbox> References: <1432891828-4816-1-git-send-email-alex.bennee@linaro.org> <1432891828-4816-6-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org, jan.kiszka@siemens.com, dahi@linux.vnet.ibm.com, r65777@freescale.com, bp@suse.de, Gleb Natapov , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Lorenzo Pieralisi , Andre Przywara , Richard Weinberger , open list To: Alex =?iso-8859-1?Q?Benn=E9e?= Return-path: Content-Disposition: inline In-Reply-To: <1432891828-4816-6-git-send-email-alex.bennee@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Fri, May 29, 2015 at 10:30:21AM +0100, Alex Benn=E9e wrote: > This is a precursor for later patches which will need to do more to > setup debug state before entering the hyp.S switch code. The existing > functionality for setting mdcr_el2 has been moved out of hyp.S and no= w > uses the value kept in vcpu->arch.mdcr_el2. >=20 > As the assembler used to previously mask and preserve MDCR_EL2.HPMN I= 've > had to add a mechanism to save the value of mdcr_el2 as a per-cpu > variable during the initialisation code. The kernel never sets this > number so we are assuming the bootcode has set up the correct value > here. >=20 > This also moves the conditional setting of the TDA bit from the hyp c= ode > into the C code which is currently used for the lazy debug register > context switch code. >=20 > Signed-off-by: Alex Benn=E9e >=20 Reviewed-by: Christoffer Dall