From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH V4 0/4] Consolidated KVM vPMU support for x86 Date: Wed, 10 Jun 2015 12:43:07 +0200 Message-ID: <20150610104307.GC20384@8bytes.org> References: <1433481616-24884-1-git-send-email-wei@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, pbonzini@redhat.com, gleb@kernel.org, rkrcmar@redhat.com To: Wei Huang Return-path: Received: from 8bytes.org ([81.169.241.247]:57790 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190AbbFJKnJ (ORCPT ); Wed, 10 Jun 2015 06:43:09 -0400 Content-Disposition: inline In-Reply-To: <1433481616-24884-1-git-send-email-wei@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jun 05, 2015 at 01:20:12AM -0400, Wei Huang wrote: > Wei Huang (4): > KVM: x86/vPMU: Define kvm_pmu_ops to support vPMU function dispatch > KVM: x86/vPMU: Create vPMU interface for VMX and SVM > KVM: x86/vPMU: Implement AMD vPMU code for KVM > KVM: x86/vPMU: Enable PMU handling for AMD PERFCTRn and EVNTSELn MSRs > > arch/x86/include/asm/kvm_host.h | 50 ++-- > arch/x86/kvm/Makefile | 4 +- > arch/x86/kvm/cpuid.c | 3 +- > arch/x86/kvm/pmu.c | 557 +++++++++++----------------------------- > arch/x86/kvm/pmu.h | 99 +++++++ > arch/x86/kvm/pmu_amd.c | 207 +++++++++++++++ > arch/x86/kvm/pmu_intel.c | 360 ++++++++++++++++++++++++++ > arch/x86/kvm/svm.c | 8 + > arch/x86/kvm/vmx.c | 8 + > arch/x86/kvm/x86.c | 76 ++---- > 10 files changed, 896 insertions(+), 476 deletions(-) > create mode 100644 arch/x86/kvm/pmu.h > create mode 100644 arch/x86/kvm/pmu_amd.c > create mode 100644 arch/x86/kvm/pmu_intel.c Okay, I reviewed and tested the series. It looks good to me, except for the one comment I had on patch 2. So feel free to add Reviewed-by: Joerg Roedel Tested-by: Joerg Roedel to patches 1, 3, and 4 in the next interation. Joerg