From: Luis Henriques <luis.henriques@canonical.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: stable <stable@vger.kernel.org>,
Nicholas Mc Guire <hofrat@osadl.org>,
Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Ralf Baechle <ralf@linux-mips.org>,
kvm@vger.kernel.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: KVM: do not sign extend on unsigned MMIO load
Date: Fri, 12 Jun 2015 13:07:46 +0100 [thread overview]
Message-ID: <20150612120746.GB1625@ares> (raw)
In-Reply-To: <5575536E.8080608@imgtec.com>
On Mon, Jun 08, 2015 at 09:33:50AM +0100, James Hogan wrote:
> Hi stable folk,
>
> On 08/05/15 15:16, James Hogan wrote:
> > On 07/05/15 13:47, Nicholas Mc Guire wrote:
> >> Fix possible unintended sign extension in unsigned MMIO loads by casting
> >> to uint16_t in the case of mmio_needed != 2.
> >>
> >> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> >
> > Looks good to me. I wrote an MMIO test to reproduce the issue, and this
> > fixes it.
> >
> > Reviewed-by: James Hogan <james.hogan@imgtec.com>
> > Tested-by: James Hogan <james.hogan@imgtec.com>
> >
> > It looks suitable for stable too (3.10+).
>
> This has reached mainline, commit ed9244e6c534612d2b5ae47feab2f55a0d4b4ced
>
> Please could it be added to stable (3.10+).
>
> Thanks
> James
Thanks, I'm queuing it for the 3.16 as well.
Cheers,
--
Luís
next prev parent reply other threads:[~2015-06-12 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 12:47 [PATCH] MIPS: KVM: do not sign extend on unsigned MMIO load Nicholas Mc Guire
2015-05-08 14:16 ` James Hogan
2015-06-08 8:33 ` James Hogan
2015-06-10 12:57 ` Jiri Slaby
2015-06-12 12:07 ` Luis Henriques [this message]
2015-06-19 19:14 ` Greg KH
2015-07-08 14:25 ` [PATCH stable <3.17] MIPS: KVM: Do " James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612120746.GB1625@ares \
--to=luis.henriques@canonical.com \
--cc=gleb@kernel.org \
--cc=hofrat@osadl.org \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).