From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis Henriques Subject: Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization Date: Fri, 12 Jun 2015 13:11:12 +0100 Message-ID: <20150612121112.GC1625@ares> References: <556486F3.5020007@solarflare.com> <556487A6.2020804@redhat.com> <5565318D.1030309@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: stable@vger.kernel.org, Paolo Bonzini , Edward Cree , Xiao Guangrong , Bandan Das , gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, LKML , Andrew Morton To: Vinson Lee Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, Jun 08, 2015 at 10:14:49PM -0700, Vinson Lee wrote: > On Tue, May 26, 2015 at 7:53 PM, Xiao Guangrong > wrote: > > > > > > On 05/26/2015 10:48 PM, Paolo Bonzini wrote: > >> > >> > >> > >> On 26/05/2015 16:45, Edward Cree wrote: > >>>>> > >>>>> This breaks older compilers that can't initialize anon structur= es. > >>>>> > >>>>> How old ? Even gcc 3.1 says you can use unnamed struct/union fi= elds and > >>>>> 3.2 is the minimum version required to compile the kernel as me= ntioned > >>>>> in the README. > >>>>> > >>>>> We could simply just name the structure, but I doubt this is th= e > >>>>> only place in the kernel code where it's being used this way :) > >>> > >>> This appears to be GCC bug #10676, see > >>> > >>> Says it was fixed in 4.6, but I believe the kernel supports GCCs = much > >>> older > >>> than that (back to 3.2). I personally hit it on 4.4.7, the versi= on > >>> shipped > >>> with RHEL6.6. > >> > >> > >> Yes, it will be fixed soon(ish). Probably before you can get rid = of the > >> obnoxious disclaimer... :) > > > > > > It has been fixed by Andrew: > > > > From: Andrew Morton > > Subject: arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug > > > > arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write': > > arch/x86/kvm/mmu.c:4256: error: unknown field 'cr0_wp' specified in > > initializer > > arch/x86/kvm/mmu.c:4257: error: unknown field 'cr4_pae' specified i= n > > initializer > > arch/x86/kvm/mmu.c:4257: warning: excess elements in union initiali= zer > > ... > > > > gcc-4.4.4 (at least) has issues when using anonymous unions in > > initializers. > > > > Fixes: edc90b7dc4ceef6 ("KVM: MMU: fix SMAP virtualization") > > Cc: Xiao Guangrong > > Cc: Paolo Bonzini > > Signed-off-by: Andrew Morton > > > > Should be found at -mm tree. > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-ker= nel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ >=20 > Hi. >=20 > Please backport "arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug" to > stable trees that have backported "KVM: MMU: fix SMAP virtualization"= =2E >=20 > Currently, the Linux 4.0.5 build is broken with GCC 4.4. >=20 > "KVM: MMU: fix SMAP virtualization" is currently queued for 3.16.y-ck= t > and 3.18.y. >=20 > Cheers, > Vinson > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html I believe you're referring to the following commit: commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803 Author: Andrew Morton Date: Wed Jun 10 11:15:02 2015 -0700 arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug I am queuing it for the 3.16 kernel. Thanks! Cheers, -- Lu=EDs