From: Christoffer Dall <christoffer.dall@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com,
peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com,
pbonzini@redhat.com, zhichao.huang@linaro.org,
jan.kiszka@siemens.com, dahi@linux.vnet.ibm.com,
r65777@freescale.com, bp@suse.de
Subject: Re: [PATCH v6 00/12] KVM Guest Debug support for arm64
Date: Wed, 24 Jun 2015 22:19:15 +0200 [thread overview]
Message-ID: <20150624201915.GC22785@cbox> (raw)
In-Reply-To: <1434716630-18260-1-git-send-email-alex.bennee@linaro.org>
On Fri, Jun 19, 2015 at 01:23:38PM +0100, Alex Bennée wrote:
> Here is V6 of the KVM Guest Debug support for arm64.
>
> The changes are even more minimal than the last round which is
> hopefully a good indication the series is ready for merging:
>
Unfortunately this series breaks the build on 32-bit ARM:
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c: In function ‘kvm_arch_vcpu_init’:
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:283:12: error: ‘struct kvm_vcpu_arch’ has no member named ‘debug_ptr’
vcpu->arch.debug_ptr = &vcpu->arch.vcpu_debug_state;
^
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:283:36: error: ‘struct kvm_vcpu_arch’ has no member named ‘vcpu_debug_state’
vcpu->arch.debug_ptr = &vcpu->arch.vcpu_debug_state;
^
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c: In function ‘kvm_arch_vcpu_ioctl_set_guest_debug’:
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:309:8: error: ‘KVM_GUESTDBG_USE_SW_BP’ undeclared (first use in this function)
KVM_GUESTDBG_USE_SW_BP | \
^
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:328:22: note: in expansion of macro ‘KVM_GUESTDBG_VALID_MASK’
if (dbg->control & ~KVM_GUESTDBG_VALID_MASK)
^
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:309:8: note: each undeclared identifier is reported only once for each function it appears in
KVM_GUESTDBG_USE_SW_BP | \
^
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:328:22: note: in expansion of macro ‘KVM_GUESTDBG_VALID_MASK’
if (dbg->control & ~KVM_GUESTDBG_VALID_MASK)
^
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:310:8: error: ‘KVM_GUESTDBG_USE_HW’ undeclared (first use in this function)
KVM_GUESTDBG_USE_HW | \
^
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:328:22: note: in expansion of macro ‘KVM_GUESTDBG_VALID_MASK’
if (dbg->control & ~KVM_GUESTDBG_VALID_MASK)
^
/home/christoffer/src/kvmarm/arm64/linux-kvm-arm/arch/arm/kvm/arm.c:336:14: error: ‘struct kvm_vcpu_arch’ has no member named ‘external_debug_state’
vcpu->arch.external_debug_state = dbg->arch;
^
make[2]: *** [arch/arm/kvm/arm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [arch/arm/kvm] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [sub-make] Error 2
-Christoffer
next prev parent reply other threads:[~2015-06-24 20:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 12:23 [PATCH v6 00/12] KVM Guest Debug support for arm64 Alex Bennée
2015-06-19 12:23 ` [PATCH v6 01/12] KVM: add comments for kvm_debug_exit_arch struct Alex Bennée
2015-06-19 12:23 ` [PATCH v6 02/12] KVM: arm64: fix misleading comments in save/restore Alex Bennée
2015-06-19 12:23 ` [PATCH v6 03/12] KVM: arm64: guest debug, define API headers Alex Bennée
2015-06-19 12:23 ` [PATCH v6 04/12] KVM: arm: guest debug, add stub KVM_SET_GUEST_DEBUG ioctl Alex Bennée
2015-06-19 12:23 ` [PATCH v6 05/12] KVM: arm: introduce kvm_arm_init/setup/clear_debug Alex Bennée
2015-06-19 12:23 ` [PATCH v6 06/12] KVM: arm64: guest debug, add SW break point support Alex Bennée
2015-06-19 12:23 ` [PATCH v6 07/12] KVM: arm64: guest debug, add support for single-step Alex Bennée
2015-06-19 12:23 ` [PATCH v6 08/12] KVM: arm64: re-factor hyp.S debug register code Alex Bennée
2015-06-24 20:19 ` Christoffer Dall
2015-06-25 6:34 ` Alex Bennée
2015-06-19 12:23 ` [PATCH v6 09/12] KVM: arm64: introduce vcpu->arch.debug_ptr Alex Bennée
2015-06-24 11:42 ` Christoffer Dall
2015-06-25 6:32 ` Alex Bennée
2015-06-25 7:46 ` Christoffer Dall
2015-06-19 12:23 ` [PATCH v6 10/12] KVM: arm64: guest debug, HW assisted debug support Alex Bennée
[not found] ` <1434716630-18260-11-git-send-email-alex.bennee-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-24 20:22 ` Christoffer Dall
2015-06-25 6:38 ` Alex Bennée
[not found] ` <87mvzoxpg6.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-25 7:49 ` Christoffer Dall
2015-06-25 10:42 ` Alex Bennée
2015-06-19 12:23 ` [PATCH v6 11/12] KVM: arm64: enable KVM_CAP_SET_GUEST_DEBUG Alex Bennée
2015-06-19 12:23 ` [PATCH v6 12/12] KVM: arm64: add trace points for guest_debug debug Alex Bennée
2015-06-24 20:19 ` Christoffer Dall [this message]
2015-06-25 6:33 ` [PATCH v6 00/12] KVM Guest Debug support for arm64 Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624201915.GC22785@cbox \
--to=christoffer.dall@linaro.org \
--cc=agraf@suse.de \
--cc=alex.bennee@linaro.org \
--cc=bp@suse.de \
--cc=dahi@linux.vnet.ibm.com \
--cc=drjones@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=r65777@freescale.com \
--cc=zhichao.huang@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).