Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 1/7] READ: add some CONTRIBUTING notes
Date: Mon, 6 Jul 2015 14:56:06 +0200	[thread overview]
Message-ID: <20150706125606.GC17217@hawk.localdomain> (raw)
In-Reply-To: <1435931327-8073-2-git-send-email-alex.bennee@linaro.org>


$SUBJECT is missing the 'ME' in README, but no biggy...

On Fri, Jul 03, 2015 at 02:48:41PM +0100, Alex Bennée wrote:
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  README | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/README b/README
> index e9869d1..4001456 100644
> --- a/README
> +++ b/README
> @@ -25,3 +25,25 @@ Directory structure:
>  ./<ARCH>:	the sources of the tests and the created objects/images
>  
>  See <ARCH>/README for architecture specific documentation.
> +
> +CONTRIBUTING:
> +=============
> +
> +Style
> +-----
> +
> +  - C: please use standard linux-with-tabs
> +  - Shell: use TABs for indentation

This is (unfortunately) not globally true. We have plenty of
lib/ and x86/ code that don't follow this style. Maybe we should
bite the bullet and fix those someday. Or, add a line to this README
that says, 'use the style of the file for consistency'.

> +
> +Patches
> +-------
> +
> +Patches are welcome at the KVM mailing list <kvm@vger.kernel.org>.
> +
> +Please prefix messages with: [kvm-unit-tests PATCH]
> +
> +You can add the following to .git/config to do this automatically for you:
> +
> +[format]
> +	subjectprefix = kvm-unit-tests PATCH
> +

This is good to document.

Thanks,
drew

  reply	other threads:[~2015-07-06 12:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-03 13:48 [kvm-unit-tests PATCH 0/7] A number of small arm/run fixes Alex Bennée
2015-07-03 13:48 ` [kvm-unit-tests PATCH 1/7] READ: add some CONTRIBUTING notes Alex Bennée
2015-07-06 12:56   ` Andrew Jones [this message]
2015-07-03 13:48 ` [kvm-unit-tests PATCH 2/7] configure: emit HOST=$host to config.mak Alex Bennée
2015-07-06 12:57   ` Andrew Jones
2015-07-03 13:48 ` [kvm-unit-tests PATCH 3/7] arm/run: set indentation defaults for emacs Alex Bennée
2015-07-06 12:59   ` Andrew Jones
2015-07-03 13:48 ` [kvm-unit-tests PATCH 4/7] run/arm: introduce usingkvm var and use it Alex Bennée
2015-07-06 13:02   ` Andrew Jones
2015-07-03 13:48 ` [kvm-unit-tests PATCH 5/7] arm/run: clean-up setting of accel options Alex Bennée
2015-07-06 13:06   ` Andrew Jones
2015-07-03 13:48 ` [kvm-unit-tests PATCH 6/7] arm/run: introduce basic option parsing Alex Bennée
2015-07-06 13:22   ` Andrew Jones
2015-07-03 13:48 ` [kvm-unit-tests PATCH 7/7] arm/run: add --debug option Alex Bennée
2015-07-06 13:14   ` Andrew Jones
2015-07-07  6:45     ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150706125606.GC17217@hawk.localdomain \
    --to=drjones@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox