From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests PATCH 5/7] arm/run: clean-up setting of accel options Date: Mon, 6 Jul 2015 15:06:36 +0200 Message-ID: <20150706130636.GG17217@hawk.localdomain> References: <1435931327-8073-1-git-send-email-alex.bennee@linaro.org> <1435931327-8073-6-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org To: Alex =?iso-8859-1?Q?Benn=E9e?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39391 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752996AbbGFNGj (ORCPT ); Mon, 6 Jul 2015 09:06:39 -0400 Content-Disposition: inline In-Reply-To: <1435931327-8073-6-git-send-email-alex.bennee@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jul 03, 2015 at 02:48:45PM +0100, Alex Benn=E9e wrote: > It would be nice to use --no-kvm but that flags a warning on pure-TCG > builds. We echo the fact we are using TCG for the benefit of interact= ive > use. >=20 > Signed-off-by: Alex Benn=E9e > --- > arm/run | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/arm/run b/arm/run > index 493ce0d..a3a33b3 100755 > --- a/arm/run > +++ b/arm/run > @@ -44,7 +44,14 @@ if $qemu $M -chardev testdev,id=3Did -initrd . 2>&= 1 \ > exit 2 > fi > =20 > -M=3D'-machine virt,accel=3Dkvm:tcg' > +M=3D'-machine virt' This M=3D'-machine virt' is now redundant with one about 10 lines above= =2E > +if [ $usingkvm =3D 1 ]; then > + M+=3D",accel=3Dkvm" > +else > + echo "Running with TCG" > + M+=3D',accel=3Dtcg' > +fi This looks good. > + > chr_testdev=3D'-device virtio-serial-device' > chr_testdev+=3D' -device virtconsole,chardev=3Dctd -chardev testdev,= id=3Dctd' > =20 > --=20 > 2.4.5 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html