From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Jones <drjones@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v2 4/4] arm/run: clean-up setting of accel
 options
Date: Tue, 7 Jul 2015 13:40:01 +0200
Message-ID: <20150707114001.GC3381@hawk.localdomain>
References: <1436252613-1540-1-git-send-email-alex.bennee@linaro.org>
 <1436252613-1540-5-git-send-email-alex.bennee@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org
To: Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:44852 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756709AbbGGLkE (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 7 Jul 2015 07:40:04 -0400
Content-Disposition: inline
In-Reply-To: <1436252613-1540-5-git-send-email-alex.bennee@linaro.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Jul 07, 2015 at 08:03:33AM +0100, Alex Benn=E9e wrote:
> It would be nice to use --no-kvm but that flags a warning on pure-TCG
> builds. We echo the fact we are using TCG for the benefit of interact=
ive
> use.
>=20
> Signed-off-by: Alex Benn=E9e <alex.bennee@linaro.org>
>=20
> ---
> v2
>   - rm redundant M=3D statement
> ---
>  arm/run | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/arm/run b/arm/run
> index 493ce0d..7266004 100755
> --- a/arm/run
> +++ b/arm/run
> @@ -32,6 +32,12 @@ if ! $qemu -machine '?' 2>&1 | grep 'ARM Virtual M=
achine' > /dev/null; then
>  fi
> =20
>  M=3D'-machine virt'
> +if [ $usingkvm =3D 1 ]; then

The "1" string here again

> +	M+=3D",accel=3Dkvm"
> +else
> +	echo "Running with TCG"
> +	M+=3D',accel=3Dtcg'
> +fi
> =20
>  if ! $qemu $M -device '?' 2>&1 | grep virtconsole > /dev/null; then
>  	echo "$qpath doesn't support virtio-console for chr-testdev. Exitin=
g."
> @@ -44,7 +50,6 @@ if $qemu $M -chardev testdev,id=3Did -initrd . 2>&1=
 \
>  	exit 2
>  fi
> =20
> -M=3D'-machine virt,accel=3Dkvm:tcg'
>  chr_testdev=3D'-device virtio-serial-device'
>  chr_testdev+=3D' -device virtconsole,chardev=3Dctd -chardev testdev,=
id=3Dctd'
> =20
> --=20
> 2.4.5
>=20
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html