From: Joerg Roedel <jroedel@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
guangrong.xiao@linux.intel.com, joerg.roedel@suse.de
Subject: Re: [PATCH] KVM: svm: remove KVM_QUIRK_CD_NW_CLEARED quirk
Date: Fri, 10 Jul 2015 17:16:03 +0200 [thread overview]
Message-ID: <20150710151603.GI2566@suse.de> (raw)
In-Reply-To: <1436529693-9743-1-git-send-email-pbonzini@redhat.com>
On Fri, Jul 10, 2015 at 02:01:33PM +0200, Paolo Bonzini wrote:
> We can disable CD unconditionally when there is no assigned device.
> KVM now forces guest PAT to all-writeback in that case, so it makes
> sense to also force CR0.CD=0.
>
> When there are assigned devices, emulate cache-disabled operation
> through the page tables. This behavior is consistent with VMX,
> where CD/NW are not touched by vmentry/vmexit.
>
> Note that buggy firmware that does not clear CD/NW is _seriously_
> old: SeaBIOS for example has been doing it since October 2008.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> arch/x86/kvm/svm.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Looks good to me.
Reviewed-by: Joerg Roedel <jroedel@suse.de>
next prev parent reply other threads:[~2015-07-10 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 12:01 [PATCH] KVM: svm: remove KVM_QUIRK_CD_NW_CLEARED quirk Paolo Bonzini
2015-07-10 15:16 ` Joerg Roedel [this message]
2015-07-10 16:04 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710151603.GI2566@suse.de \
--to=jroedel@suse.de \
--cc=guangrong.xiao@linux.intel.com \
--cc=joerg.roedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).