From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests PATCH] alloc: only warn once if we run out of log entries Date: Wed, 29 Jul 2015 16:16:42 +0200 Message-ID: <20150729141642.GC3722@hawk.localdomain> References: <1437739647-30313-1-git-send-email-drjones@redhat.com> <55B8DAB3.9070200@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43774 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753141AbbG2OQq (ORCPT ); Wed, 29 Jul 2015 10:16:46 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id C2407A80 for ; Wed, 29 Jul 2015 14:16:45 +0000 (UTC) Content-Disposition: inline In-Reply-To: <55B8DAB3.9070200@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 29, 2015 at 03:52:51PM +0200, Paolo Bonzini wrote: > > > On 24/07/2015 14:07, Andrew Jones wrote: > > @@ -58,6 +59,7 @@ void phys_alloc_set_minimum_alignment(phys_addr_t align) > > static phys_addr_t phys_alloc_aligned_safe(phys_addr_t size, > > phys_addr_t align, bool safe) > > { > > + static bool not_warned = true; > > I wouldn't object to not having "not" in the name of this variable. :) yeah, actually I don't like the not in there either, now that you mention it. v2 coming. Thanks, drew > > Otherwise looks okay. > > Paolo > > > phys_addr_t addr, size_orig = size; > > u64 top_safe = top; > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html