From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Jones <drjones@redhat.com>
Subject: Re: [kvm-unit-tests RFC PATCH] arm/tlbflush.c: TLB flushing torture
 test [DEV]
Date: Wed, 29 Jul 2015 16:36:30 +0200
Message-ID: <20150729143630.GD3722@hawk.localdomain>
References: <1437744306-7911-1-git-send-email-alex.bennee@linaro.org>
 <20150727075411.GA3758@hawk.localdomain>
 <55B8DC23.5040007@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>,
	mttcg@greensocs.com, mark.burton@greensocs.com,
	fred.konrad@greensocs.com, a.spyridakis@virtualopensystems.com,
	kvm@vger.kernel.org
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:36017 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752701AbbG2Ogf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 29 Jul 2015 10:36:35 -0400
Content-Disposition: inline
In-Reply-To: <55B8DC23.5040007@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Jul 29, 2015 at 03:58:59PM +0200, Paolo Bonzini wrote:
> 
> 
> On 27/07/2015 09:54, Andrew Jones wrote:
> > Also, please rename to tlbflush-test.c to differentiate it
> > from an implementation of tlbflush support, and to make
> > the standalone test name (if we commit those patches) more
> > descriptive.
> 
> I disagree here.  Support code would go in lib/arm.

Generally yes, and for arm, so far yes, but not always. In x86 we
have kvmclock.c (support) vs. kvmclock_test.c (the test). And powerpc
will have a support C file in powerpc vs. lib/powerpc as well, as I
feel it fits better there, since it's really part of cstart.

But that said, I'm not overly opposed to dropping -test from the
common case, only using it when necessary. We can also append -test
for standalone test names later, if we want to.

Thanks,
drew