From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Rutherford Subject: Re: [PATCH v5 3/4] KVM: x86: Add EOI exit bitmap inference Date: Wed, 29 Jul 2015 13:27:14 -0700 Message-ID: <20150729202714.GA32444@google.com> References: <1438039062-3168-1-git-send-email-srutherford@google.com> <1438039062-3168-3-git-send-email-srutherford@google.com> <55B8C931.5090300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mail-pd0-f169.google.com ([209.85.192.169]:33415 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbbG2U1g (ORCPT ); Wed, 29 Jul 2015 16:27:36 -0400 Received: by pdbnt7 with SMTP id nt7so11519045pdb.0 for ; Wed, 29 Jul 2015 13:27:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55B8C931.5090300@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jul 29, 2015 at 02:38:09PM +0200, Paolo Bonzini wrote: > > > On 28/07/2015 01:17, Steve Rutherford wrote: > > diff --git a/arch/x86/kvm/ioapic.h b/arch/x86/kvm/ioapic.h > > index d8cc54b..f6ce112 100644 > > --- a/arch/x86/kvm/ioapic.h > > +++ b/arch/x86/kvm/ioapic.h > > @@ -9,6 +9,7 @@ struct kvm; > > struct kvm_vcpu; > > > > #define IOAPIC_NUM_PINS KVM_IOAPIC_NUM_PINS > > +#define MAX_NR_RESERVED_IOAPIC_PINS 48 > > Why is this needed? This constant is used to bound the number of IOAPIC pins that are reservable when enabling KVM_CAP_SPLIT_IRQCHIP. IIRC, x86 doesn't support more than 2 IOAPICs. > > Paolo > > > #define IOAPIC_VERSION_ID 0x11 /* IOAPIC version */ > > #define IOAPIC_EDGE_TRIG 0 > > #define IOAPIC_LEVEL_TRIG 1