From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests PATCH 11/14] powerpc/ppc64: add rtas_power_off Date: Tue, 4 Aug 2015 09:47:59 +0200 Message-ID: <20150804074759.GD13384@hawk.localdomain> References: <1438612891-3718-1-git-send-email-drjones@redhat.com> <1438612891-3718-12-git-send-email-drjones@redhat.com> <55BFA001.6070900@redhat.com> <20150804040952.GE3080@voom.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, dgibson@redhat.com, agraf@suse.de, thuth@redhat.com, lvivier@redhat.com To: David Gibson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41067 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753212AbbHDHsF (ORCPT ); Tue, 4 Aug 2015 03:48:05 -0400 Content-Disposition: inline In-Reply-To: <20150804040952.GE3080@voom.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Aug 04, 2015 at 02:09:52PM +1000, David Gibson wrote: > On Mon, Aug 03, 2015 at 07:08:17PM +0200, Paolo Bonzini wrote: > > > > > > On 03/08/2015 16:41, Andrew Jones wrote: > > > Add enough RTAS support to support power-off, and apply it to > > > exit(). > > > > > > Signed-off-by: Andrew Jones > > > > Why not use virtio-mmio + testdev on ppc as well? Similar to how we're > > not using PSCI on ARM or ACPI on x86. > > Strange as it seems, MMIO is actually a PITA for a simple pseries > guest like this. Basically, you have to enable the MMU - which > requires a whole bunch of setup - in order to perform cache-inhibited > loads and stores, which is what you need for IO. > > There are hypercalls to sidestep this (H_LOGICAL_CI_LOAD and > H_LOGICAL_CI_STORE), but having a hypercall and KVM exit for every IO > access may be hideously slow. > > In early development we did have a hypercall mediated virtio model, > but it was abandoned once we got PCI working. So I think by yours and Alex's responses, if we want testdev support then we should target using pci to expose it. I'm ok with that, but prefer not to be distracted with it while getting ppc kickstarted. So, question for Paolo, are you OK with the exitcode snooper "cheat"? Thanks, drew > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson