From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 3/5] KVM: add KVM_USER_EXIT vm ioctl for userspace exit
Date: Wed, 5 Aug 2015 15:48:22 +0200 [thread overview]
Message-ID: <20150805134821.GA1481@potion.brq.redhat.com> (raw)
In-Reply-To: <55C211EB.2030704@redhat.com>
2015-08-05 15:38+0200, Paolo Bonzini:
> On 05/08/2015 15:34, Radim Krčmář wrote:
>> vcpu ioctl should only be issued by the vcpu thread so it would
>> significantly limit use.
>
> That's a general limitation, but you can lift it for particular ioctls.
>
> See in particular this:
>
> #if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS)
> /*
> * Special cases: vcpu ioctls that are asynchronous to vcpu execution,
> * so vcpu_load() would break it.
> */
> if (ioctl == KVM_S390_INTERRUPT || ioctl == KVM_S390_IRQ || ioctl == KVM_INTERRUPT)
> return kvm_arch_vcpu_ioctl(filp, ioctl, arg);
> #endif
>
> You can add an "if (ioctl == KVM_USER_EXIT)" before.
Thanks, it looks to be safe, I'll put it in v2.
next prev parent reply other threads:[~2015-08-05 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 13:21 [PATCH 0/5] KVM: optimize userspace exits with a new ioctl Radim Krčmář
2015-08-05 13:21 ` [PATCH 1/5] KVM: add kvm_has_request wrapper Radim Krčmář
2015-08-05 13:21 ` [PATCH 2/5] KVM: add KVM_REQ_EXIT request for userspace exit Radim Krčmář
2015-08-05 13:21 ` [PATCH 3/5] KVM: add KVM_USER_EXIT vm ioctl " Radim Krčmář
2015-08-05 13:29 ` Paolo Bonzini
2015-08-05 13:34 ` Radim Krčmář
2015-08-05 13:38 ` Paolo Bonzini
2015-08-05 13:48 ` Radim Krčmář [this message]
2015-08-05 13:21 ` [PATCH 4/5] KVM: optimize common cases in KVM_USER_EXIT Radim Krčmář
2015-08-05 13:21 ` [PATCH 5/5] KVM: x86: add request_exits debug counter Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805134821.GA1481@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox