Re: [kvm-unit-tests PATCH 3/3] arm/run: use ACCEL to choose between kvm and tcg

Andrew Jones
2015-08-07T08:01:02Z

On Thu, Aug 06, 2015 at 07:29:00PM +0100, Alex Bennée wrote:
>
> Andrew Jones <drjones@redhat.com> writes:
>
> > Inspired by a patch by Alex Bennée. This version uses a new
> > unittests.cfg variable and includes support for DRYRUN.
> >
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > ---
> >
> > Another difference with Alex's patch is we no longer output
> > 'Running with TCG', as I don't think it's necessary. The
> > command line captures that, and the whole point of the patch
> > is to silence the '"kvm" accelerator not found.' messages
> > anyway.
>
> Yeah that makes sense.
>
> >
> > arm/run | 36 ++++++++++++++++++++++++++++++------
> > arm/unittests.cfg | 4 +++-
> > run_tests.sh | 3 ++-
> > scripts/functions.bash | 8 ++++++--
> > 4 files changed, 41 insertions(+), 10 deletions(-)
> <snip>
>
> I see your re-posting so I'll do a full review then. Is there a branch I
> can re-base my stuff on top of for now?

OK, https://github.com/rhdrjones/kvm-unit-tests/commits/staging has been
updated. BTW, that branch is anything but stable. It'll get a rebase
anytime upstream master or next is updated, and iff neither of those are
a sufficient base (so not only is it unstable, but it could go stale...)
Hopefully atm it's useful for you to rebase on though.

Thanks,
drew

>
> --
> Alex Bennée
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html