Re: [kvm-unit-tests PATCH 3/3] arm/run: use ACCEL to choose between kvm and tcg

Alex Bennée
2015-08-06T18:29:04Z

Andrew Jones <drjones@redhat.com> writes:

> Inspired by a patch by Alex Bennée. This version uses a new
> unittests.cfg variable and includes support for DRYRUN.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>
> Another difference with Alex's patch is we no longer output
> 'Running with TCG', as I don't think it's necessary. The
> command line captures that, and the whole point of the patch
> is to silence the '"kvm" accelerator not found.' messages
> anyway.

Yeah that makes sense.

>
> arm/run | 36 ++++++++++++++++++++++++++++++------
> arm/unittests.cfg | 4 +++-
> run_tests.sh | 3 ++-
> scripts/functions.bash | 8 ++++++--
> 4 files changed, 41 insertions(+), 10 deletions(-)
<snip>

I see your re-posting so I'll do a full review then. Is there a branch I
can re-base my stuff on top of for now?

--
Alex Bennée