From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH kvmtool] kvm__emulate_io: Don't call br_read_unlock() twice on IO error Date: Fri, 7 Aug 2015 15:37:23 +0100 Message-ID: <20150807143723.GA8726@arm.com> References: <20150806183944.GA6720@cloud> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "kvm@vger.kernel.org" To: Josh Triplett Return-path: Received: from foss.arm.com ([217.140.101.70]:42990 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932159AbbHGOhZ (ORCPT ); Fri, 7 Aug 2015 10:37:25 -0400 Content-Disposition: inline In-Reply-To: <20150806183944.GA6720@cloud> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Aug 06, 2015 at 07:39:44PM +0100, Josh Triplett wrote: > The IO error path in kvm__emulate_io would call br_read_unlock(), then > goto error, which would call br_read_unlock() again. Refactor the > control flow to have only one exit path and one call to > br_read_unlock(). Thanks, Josh. I applied all three patches! Will