From mboxrd@z Thu Jan  1 00:00:00 1970
From: Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] kvmtool Makefile: relax arm test
Date: Thu, 10 Sep 2015 11:30:11 +0100
Message-ID: <20150910103011.GB22439@arm.com>
References: <1441279212-8797-1-git-send-email-riku.voipio@linaro.org>
 <55E96E23.2090802@arm.com>
 <CAAqcGH=srMXr3O+zffc4bKLP2R1Z+FAf9k-J-kou48Fd0P2-zg@mail.gmail.com>
 <55E97B47.7050100@arm.com>
 <CAAqcGH=4MBSuZC2wd9QDR1hH7s0fSm5s-n5unc7cu6h-cjP9UA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andre Przywara <Andre.Przywara@arm.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Riku Voipio <riku.voipio@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from foss.arm.com ([217.140.101.70]:33344 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752116AbbIJKaL (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 10 Sep 2015 06:30:11 -0400
Content-Disposition: inline
In-Reply-To: <CAAqcGH=4MBSuZC2wd9QDR1hH7s0fSm5s-n5unc7cu6h-cjP9UA@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Sep 10, 2015 at 06:45:59AM +0100, Riku Voipio wrote:
> On 4 September 2015 at 14:06, Andre Przywara <andre.przywara@arm.com> wrote:
> > On 04/09/15 11:52, Riku Voipio wrote:
> >> On 4 September 2015 at 13:10, Andre Przywara <andre.przywara@arm.com> wrote:
> >>> On 03/09/15 12:20, riku.voipio@linaro.org wrote:
> >>>> From: Riku Voipio <riku.voipio@linaro.org>
> >>>>
> >>>> Currently Makefile accepts only armv7l.* When building kvmtool under 32bit
> >>>> personality on Aarch64 machines, uname -m reports "armv8l", so build fails.
> >>>> We expect doing 32bit arm builds in Aarch64 to become standard the same way
> >>>> people do i386 builds on x86_64 machines.
> >>>>
> >>>> Make the sed test a little more greedy so armv8l becomes acceptable.
> >>>>
> >>>> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> >>>
> >>> The patch looks OK to me, I just wonder how you do the actual build
> >>> within the linux32 environment?
> >>> Do you have an arm cross compiler installed and set CROSS_COMPILE? Or is
> >>> there a magic compiler (driver) which uses uname -m as well?
> >>> And what would be the difference to setting ARCH=arm as well? Just
> >>> convenience?
> >>
> >> It's just an arm32 chroot, with an native arm32 compiler. The chroot
> >> is on an arm64 machine since these tend to be much faster than arm32
> >> hardware.
> >
> > Oh right, a chroot, didn't think about the obvious ;-)
> > Also it applies to 64-bit kernels with 32-bit root filesystems, I think.
> > So:
> >
> > Acked-by: Andre Przywara <andre.przywara@arm.com>
> 
> Ping?

Applied and pushed, thanks.

In future, it's best to Cc me if you want to make sure stuff doesn't
get missed :)

Cheers,

Will