From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v4 3/7] KVM: arm/arm64: Fix the documentation Date: Wed, 7 Oct 2015 22:04:39 +0200 Message-ID: <20151007200439.GC14315@cbox> References: <5b6b8e9e002bc6a9cc5e6a881032d6b930830e74.1443451687.git.p.fedin@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Peter Maydell , Marc Zyngier , Andre Przywara To: Pavel Fedin Return-path: Received: from mail-lb0-f171.google.com ([209.85.217.171]:34862 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbbJGUE2 (ORCPT ); Wed, 7 Oct 2015 16:04:28 -0400 Received: by lbwr8 with SMTP id r8so23843386lbw.2 for ; Wed, 07 Oct 2015 13:04:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5b6b8e9e002bc6a9cc5e6a881032d6b930830e74.1443451687.git.p.fedin@samsung.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Sep 28, 2015 at 06:27:30PM +0300, Pavel Fedin wrote: > During refactoring we noticed some mistakes in the documentation. > Correct them. > > Signed-off-by: Pavel Fedin > --- > Documentation/virtual/kvm/devices/arm-vgic.txt | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/Documentation/virtual/kvm/devices/arm-vgic.txt b/Documentation/virtual/kvm/devices/arm-vgic.txt > index 3fb9054..4727829 100644 > --- a/Documentation/virtual/kvm/devices/arm-vgic.txt > +++ b/Documentation/virtual/kvm/devices/arm-vgic.txt > @@ -44,28 +44,29 @@ Groups: > Attributes: > The attr field of kvm_device_attr encodes two values: > bits: | 63 .... 40 | 39 .. 32 | 31 .... 0 | > - values: | reserved | cpu id | offset | > + values: | reserved | cpu idx | offset | why should this be changed to cpu idx? > > All distributor regs are (rw, 32-bit) > > The offset is relative to the "Distributor base address" as defined in the > GICv2 specs. Getting or setting such a register has the same effect as > - reading or writing the register on the actual hardware from the cpu > - specified with cpu id field. Note that most distributor fields are not > - banked, but return the same value regardless of the cpu id used to access > - the register. > + reading or writing the register on the actual hardware from the cpu whose > + index is specified with cpu idx field. Note that most distributor fields > + are not banked, but return the same value regardless of the cpu idx used to > + access the register. > Limitations: > - Priorities are not implemented, and registers are RAZ/WI > - Currently only implemented for KVM_DEV_TYPE_ARM_VGIC_V2. > Errors: > - -ENODEV: Getting or setting this register is not yet supported > + -ENXIO: Getting or setting this register is not yet supported > -EBUSY: One or more VCPUs are running > + -EINVAL: Invalid CPU index supplied > > KVM_DEV_ARM_VGIC_GRP_CPU_REGS > Attributes: > The attr field of kvm_device_attr encodes two values: > bits: | 63 .... 40 | 39 .. 32 | 31 .... 0 | > - values: | reserved | cpu id | offset | > + values: | reserved | cpu idx | offset | > > All CPU interface regs are (rw, 32-bit) > > @@ -91,8 +92,9 @@ Groups: > - Priorities are not implemented, and registers are RAZ/WI > - Currently only implemented for KVM_DEV_TYPE_ARM_VGIC_V2. > Errors: > - -ENODEV: Getting or setting this register is not yet supported > + -ENXIO: Getting or setting this register is not yet supported > -EBUSY: One or more VCPUs are running > + -EINVAL: Invalid CPU index supplied > > KVM_DEV_ARM_VGIC_GRP_NR_IRQS > Attributes: > -- > 2.4.4 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html