From: Christoffer Dall <christoffer.dall@linaro.org>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Peter Maydell <peter.maydell@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH v4 4/7] KVM: arm64: Implement vGICv3 distributor and redistributor access from userspace
Date: Wed, 7 Oct 2015 22:07:11 +0200 [thread overview]
Message-ID: <20151007200711.GD14315@cbox> (raw)
In-Reply-To: <9d42bb0fd6abf17bae0179c4233c45d267c25162.1443451687.git.p.fedin@samsung.com>
Hi Pavel,
On Mon, Sep 28, 2015 at 06:27:31PM +0300, Pavel Fedin wrote:
> The access is done similar to vGICv2, using KVM_DEV_ARM_VGIC_GRP_DIST_REGS
> and KVM_DEV_ARM_VGIC_GRP_REDIST_REGS with KVM_SET_DEVICE_ATTR and
> KVM_GET_DEVICE_ATTR ioctls. Since GICv3 can handle large number of CPUs,
> KVM_DEV_ARM_VGIC_CPUID_MASK has been extended to 20 bits. This is enough
> for 1048576 CPUs.
>
> Some registers are 64-bit wide according to the specification.
> KVM_DEV_ARM_VGIC_64BIT flag is introduced, allowing to perform full 64-bit
> accesses. vgic_attr_regs_access() has also been fixed up in order to be
> able to perform 64-bit accesses correctly.
>
Apologies for the long delay in responding to this.
We went over this and discussed this during Linaro Connect, and we came
up with an API that we believe considers the future, works well with how
things are going to be designed in QEMU, and follows the architecture.
I'm sorry to make you rework your patches at this stage, but I'd like
you to take a look at the patch for the API that I just sent out
(subject: KVM: arm/arm64: Add VGICv3 save/restore API documentation) and
adapt this patch set to use that API instead and then I'll review that.
Thanks,
-Christoffer
next prev parent reply other threads:[~2015-10-07 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 15:27 [PATCH v4 0/7] KVM: arm64: Implement API for vGICv3 live migration Pavel Fedin
2015-09-28 15:27 ` [PATCH v4 1/7] KVM: arm/arm64: Move endianness conversion out of vgic_attr_regs_access() Pavel Fedin
2015-09-28 15:27 ` [PATCH v4 2/7] KVM: arm/arm64: Refactor vGIC attributes handling code Pavel Fedin
2015-09-28 15:27 ` [PATCH v4 3/7] KVM: arm/arm64: Fix the documentation Pavel Fedin
2015-10-07 20:04 ` Christoffer Dall
2015-10-08 6:52 ` Pavel Fedin
2015-10-08 8:24 ` Christoffer Dall
2015-10-12 7:16 ` Pavel Fedin
2015-10-12 11:56 ` Christoffer Dall
2015-09-28 15:27 ` [PATCH v4 4/7] KVM: arm64: Implement vGICv3 distributor and redistributor access from userspace Pavel Fedin
2015-10-07 20:07 ` Christoffer Dall [this message]
2015-09-28 15:27 ` [PATCH v4 5/7] KVM: arm64: Refactor system register handlers Pavel Fedin
2015-09-28 15:27 ` [PATCH v4 6/7] KVM: arm64: Introduce find_reg_by_id() Pavel Fedin
2015-09-28 15:27 ` [PATCH v4 7/7] Implement vGICv3 CPU interface access Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007200711.GD14315@cbox \
--to=christoffer.dall@linaro.org \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).