From: Christoffer Dall <christoffer.dall@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
Pavel Fedin <p.fedin@samsung.com>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: Re: [PATCH 0/2] KVM: arm/arm64: Clean up some obsolete code
Date: Thu, 8 Oct 2015 14:33:09 +0200 [thread overview]
Message-ID: <20151008123309.GB20936@cbox> (raw)
In-Reply-To: <5616503A.7060504@arm.com>
On Thu, Oct 08, 2015 at 12:15:06PM +0100, Andre Przywara wrote:
> Hi,
>
> On 08/10/15 11:56, Marc Zyngier wrote:
> > On 08/10/15 11:14, Christoffer Dall wrote:
> >> Hi Pavel,
> >>
> >> On Fri, Oct 02, 2015 at 05:44:27PM +0300, Pavel Fedin wrote:
> >>> Current KVM code has lots of old redundancies, which can be cleaned up.
> >>> This patchset is actually a better alternative to
> >>> http://www.spinics.net/lists/arm-kernel/msg430726.html, which allows to
> >>> keep piggy-backed LRs. The idea is based on the fact that our code also
> >>> maintains LR state in elrsr, and this information is enough to track LR
> >>> usage.
> >>>
> >>> This patchset is made against linux-next of 02.10.2015. Thanks to Andre
> >>> for pointing out some 4.3 specifics.
> >>>
> >> I'm not opposed to these changes, they clean up the data structures
> >> which is definitely a good thing.
> >>
> >> I am a bit worries about how/if this is going to conflict with the ITS
> >> series and other patches in flight touchignt he vgic.
> >>
> >> Marc/Andre, any thoughts on this?
> >
> > I don't mind the simplification (Andre was already removing the
> > piggybacking stuff as part of his ITS series). I'm a bit more cautious
> > about the sync_elrsr stuff, but that's mostly because I've only read the
> > patch in a superficial way.
> >
> > But yes, this is probably going to clash, unless we make this part of an
> > existing series (/me looks at André... ;-)
>
> Yes, I am looking at merging this. From the discussion with Pavel I
> remember some things that I disagreed with, so I may propose a follow-up
> patch. I will give this a try tomorrow.
>
From a maintainer perspective I'd much prefer Andre take these patches
as part of his series and send everything together in one go.
Thanks,
-Christoffer
next prev parent reply other threads:[~2015-10-08 12:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 14:44 [PATCH 0/2] KVM: arm/arm64: Clean up some obsolete code Pavel Fedin
2015-10-02 14:44 ` [PATCH 1/2] KVM: arm/arm64: Optimize away redundant LR tracking Pavel Fedin
2015-10-12 16:56 ` Andre Przywara
2015-10-13 15:41 ` Christoffer Dall
2015-10-22 21:42 ` Christoffer Dall
2015-10-23 7:12 ` Pavel Fedin
2015-10-02 14:44 ` [PATCH 2/2] KVM: arm/arm64: Merge vgic_set_lr() and vgic_sync_lr_elrsr() Pavel Fedin
2015-10-22 21:54 ` Christoffer Dall
2015-10-08 10:14 ` [PATCH 0/2] KVM: arm/arm64: Clean up some obsolete code Christoffer Dall
2015-10-08 10:55 ` Pavel Fedin
2015-10-08 10:56 ` Marc Zyngier
2015-10-08 11:15 ` Andre Przywara
2015-10-08 12:04 ` Pavel Fedin
2015-10-08 12:33 ` Christoffer Dall [this message]
2015-10-08 11:36 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008123309.GB20936@cbox \
--to=christoffer.dall@linaro.org \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=p.fedin@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).