From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table Date: Tue, 13 Oct 2015 08:42:37 +0300 Message-ID: <20151013082734-mutt-send-email-mst@redhat.com> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-24-git-send-email-guangrong.xiao@linux.intel.com> <20151012133853-mutt-send-email-mst@redhat.com> <561C92EE.60609@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46366 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbbJMFmp (ORCPT ); Tue, 13 Oct 2015 01:42:45 -0400 Content-Disposition: inline In-Reply-To: <561C92EE.60609@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Oct 13, 2015 at 01:13:18PM +0800, Xiao Guangrong wrote: > > > >> #endif > > > >This header is too small to be worth it. > >nvdimm_get_built_list seems to be the only interface - > >just stick it in the header you have under include. > > > > Other functions are introudced and included into it in later patches, > it includes the internal things shared between nvdimm device, nvdimm ACPI, > nvdimm namespace. > > Furthermore, this is a internal include file, it is not bad i think. Each time we do this, this seems to invite abuse where people add APIs without documenting them. I guess I could buy this if you add nvdimm_defs.h with just internal things such as layout of the buffer used for communication between ACPI and hardware. -- MST