From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table Date: Tue, 13 Oct 2015 09:07:14 +0300 Message-ID: <20151013085854-mutt-send-email-mst@redhat.com> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-24-git-send-email-guangrong.xiao@linux.intel.com> <561C93E0.6080602@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Dan Williams , Paolo Bonzini , imammedo@redhat.com, Gleb Natapov , mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, KVM list , qemu-devel@nongnu.org To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36829 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665AbbJMGHW (ORCPT ); Tue, 13 Oct 2015 02:07:22 -0400 Content-Disposition: inline In-Reply-To: <561C93E0.6080602@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Oct 13, 2015 at 01:17:20PM +0800, Xiao Guangrong wrote: > >Would it worth including / copying the ACPICA header files directly? > > > >https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/acpi/actbl1.h > >https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/acpi/acuuid.h > > Good point, Dan. > > These files are not exported under uapi/ so that it is not good to directly > include it, i will learn the definition and adjust it to QEMU's code style > in the next version. > > Thanks! > You can talk to acpica guys to try to move acuuid.h to uapi if you like. But there's not a lot there that we need, I'm not sure it's worth it. -- MST