From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI Date: Mon, 19 Oct 2015 11:18:36 +0200 Message-ID: <20151019111836.2e830737@igors-macbook-pro.local> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-23-git-send-email-guangrong.xiao@linux.intel.com> <20151019095612-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60355 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753705AbbJSJSo (ORCPT ); Mon, 19 Oct 2015 05:18:44 -0400 In-Reply-To: <20151019095612-mutt-send-email-mst@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 19 Oct 2015 09:56:12 +0300 "Michael S. Tsirkin" wrote: > On Sun, Oct 11, 2015 at 11:52:54AM +0800, Xiao Guangrong wrote: [...] > > diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h > > index f6bd2c4..aa95961 100644 > > --- a/include/hw/mem/nvdimm.h > > +++ b/include/hw/mem/nvdimm.h > > @@ -15,6 +15,10 @@ > > > > #include "hw/mem/dimm.h" > > > > +/* Memory region 0xFF00000 ~ 0xFFF00000 is reserved for NVDIMM > > ACPI. */ +#define NVDIMM_ACPI_MEM_BASE 0xFF000000ULL Michael, If it's ok to map control RAM region directly from QEMU at arbitrary location let's do the same for VMGENID too (i.e. use v16 implementation which does exactly the same thing as this series). > > +#define NVDIMM_ACPI_MEM_SIZE 0xF00000ULL [...]