From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM
 ACPI
Date: Mon, 19 Oct 2015 11:46:35 +0200
Message-ID: <20151019114635.510b031c@igors-macbook-pro.local>
References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com>
	<1444535584-18220-23-git-send-email-guangrong.xiao@linux.intel.com>
	<20151019095612-mutt-send-email-mst@redhat.com>
	<56249B59.1040103@linux.intel.com>
	<20151019103754-mutt-send-email-mst@redhat.com>
	<56249F4D.10709@linux.intel.com>
	<20151019121707-mutt-send-email-mst@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com,
	stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
	dan.j.williams@intel.com, kvm@vger.kernel.org,
	qemu-devel@nongnu.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:41694 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753631AbbJSJqo (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 19 Oct 2015 05:46:44 -0400
In-Reply-To: <20151019121707-mutt-send-email-mst@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 19 Oct 2015 12:17:22 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Oct 19, 2015 at 03:44:13PM +0800, Xiao Guangrong wrote:
> > 
> > 
> > On 10/19/2015 03:39 PM, Michael S. Tsirkin wrote:
> > >On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote:
> > >>>>+        nvdimm_init_memory_state(&pcms->nvdimm_memory,
> > >>>>system_memory, machine,
> > >>>>+                                 TARGET_PAGE_SIZE);
> > >>>>+
> > >>>
> > >>>Shouldn't this be conditional on presence of the nvdimm device?
> > >>>
> > >>
> > >>We will enable hotplug on nvdimm devices in the near future once
> > >>Linux driver is ready. I'd keep it here for future development.
> > >
> > >No, I don't think we should add stuff unconditionally. If not
> > >nvdimm, some other flag should indicate user intends to hotplug
> > >things.
> > >
> > 
> > Actually, it is not unconditionally which is called if parameter
> > "-m aaa, maxmem=bbb" (aaa < bbb) is used. It is on the some path of
> > memoy-hotplug initiation.
> > 
> 
> Right, but that's not the same as nvdimm.
> 

it could be pc-machine property, then it could be turned on like this:
 -machine nvdimm_support=on