From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid handling Date: Wed, 18 Nov 2015 13:58:55 -0200 Message-ID: <20151118155855.GI20436@thinpad.lan.raisama.net> References: <1447813217-10532-1-git-send-email-huaitong.han@intel.com> <1447813217-10532-2-git-send-email-huaitong.han@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pbonzini@redhat.com, rth@twiddle.net, afaerber@suse.de, qemu-devel@nongnu.org, kvm@vger.kernel.org To: Huaitong Han Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36436 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755460AbbKRP65 (ORCPT ); Wed, 18 Nov 2015 10:58:57 -0500 Content-Disposition: inline In-Reply-To: <1447813217-10532-2-git-send-email-huaitong.han@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Nov 18, 2015 at 10:20:15AM +0800, Huaitong Han wrote: [...] > @@ -408,6 +420,13 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = { > .cpuid_reg = R_EBX, > .tcg_features = TCG_7_0_EBX_FEATURES, > }, > + [FEAT_7_0_ECX] = { > + .feat_names = cpuid_7_0_ecx_feature_name, > + .cpuid_eax = 7, > + .cpuid_needs_ecx = true, .cpuid_ecx = 0, > + .cpuid_reg = R_ECX, > + .tcg_features = TCG_7_0_ECX_FEATURES, > + }, The patch looks good, but when we add the feature names to cpuid_7_0_ecx_feature_name, QEMU will consider them as migratable, but they are truly migratable only after we add the ext_save_areas entry. We can fix this by moving cpuid_7_0_ecx_feature_name to patch 2/3 (or to a separate patch, to be applied after 2/3). -- Eduardo