From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid handling Date: Thu, 19 Nov 2015 12:56:04 -0200 Message-ID: <20151119145604.GH23717@thinpad.lan.raisama.net> References: <1447813217-10532-1-git-send-email-huaitong.han@intel.com> <1447813217-10532-2-git-send-email-huaitong.han@intel.com> <20151118155855.GI20436@thinpad.lan.raisama.net> <1447915017.3961.22.camel@intel.com> <564DAE39.3050203@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Han, Huaitong" , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" , "rth@twiddle.net" , "afaerber@suse.de" To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52596 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934320AbbKSO4H (ORCPT ); Thu, 19 Nov 2015 09:56:07 -0500 Content-Disposition: inline In-Reply-To: <564DAE39.3050203@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 19, 2015 at 12:10:49PM +0100, Paolo Bonzini wrote: > > > On 19/11/2015 07:36, Han, Huaitong wrote: > > I understand it has always been that QEMU considers the feature of > > cpuid_7_0_ecx_feature_name as migratable. If the feature is > > unmigratable, it will been added to unmigratable_flags. > > > > A series of patches do complete a full function, moving > > cpuid_7_0_ecx_feature_name to 2/3 patch may make 2/3 patch look > > better, but make 1/3 patch look somewhat incomplete. > > > > Maybe it is a solution that adding the feature to unmigratable_flags in > > 1/3 patch, and deleting unmigratable_flags in 2/3 patch, but I think it > > is pointless. > > Or just squash everything together. After all we're talking of > > 4 files changed, 55 insertions(+), 1 deletion(-) > > It's not a large patch. It makes sense. Adding the state to X86CPU (2/3) is useful only if we migrate it (3/3), and adding the feature names (1/3) is useful only if we can handle the new state. I will squash everything together when applying, in case there's no new version. -- Eduardo