Re: [PATCH kvm-unit-tests 1/6] lib/report: allow test skipping

Radim Krčmář
2015-12-15T12:54:53Z

2015-12-14 16:12-0600, Andrew Jones:
> On Mon, Dec 14, 2015 at 04:00:19PM -0600, Andrew Jones wrote:
>> On Mon, Dec 14, 2015 at 10:24:16PM +0100, Radim Krčmář wrote:
>> > ---
>> > diff --git a/lib/libcflat.h b/lib/libcflat.h
>> > -void va_report_xfail(const char *msg_fmt, bool xfail, bool cond, va_list va)
>> > +void va_report(const char *msg_fmt, bool pass, bool xfail, bool skip, va_list va)
>>
>> Line greater than 80 char here. Yes, that was supposed to induce an eye
>> roll. But... this file doesn't have any "long" lines yet, so we could
>> continue avoiding them.

Ah, yeah, young'uns these days ...

>> > diff --git a/run_tests.sh b/run_tests.sh
>> > index fad22a935b00..4d813b9a7084 100755
>> > --- a/run_tests.sh
>> > +++ b/run_tests.sh
>> > @@ -55,12 +55,15 @@ function run()
>> > # extra_params in the config file may contain backticks that need to be
>> > # expanded, so use eval to start qemu
>> > eval $cmdline >> test.log
>> > + # The first bit of return value is too hard to use, just skip it.
>> > + # Unit-tests' return value is shifted by one.
>> > + case $(($? >> 1)) in
>> > + 0) echo -ne "\e[32mPASS\e[0m" ;;
>> > + 77) echo -ne "skip" ;;
>>
>> Why not "\e[31mSKIP\e[0m"? (and without those escape sequences echo doesn't
>> need -e)
>
> oops, copy+paste error, I meant to put use color code 33 (yellow).

Will do. (I started with yellow SKIP, but then kept white skip as I
didn't research the reason why it was chosen.)