Re: [PATCH kvm-unit-tests 2/6] x86/*: report skipped tests

Radim Krčmář
2015-12-15T12:58:44Z

2015-12-14 16:07-0600, Andrew Jones:
> On Mon, Dec 14, 2015 at 10:24:17PM +0100, Radim Krčmář wrote:
>> No care to consistency or exhaustivity was given.
>>
>> (svm-disabled test should be redone and it's weird that x86/hyperv_synic
>> is about the only one that does report_skip when unsupported.)
>>
>> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>> ---
>> diff --git a/x86/apic.c b/x86/apic.c
>> @@ -55,9 +54,9 @@ static int enable_tsc_deadline_timer(void)
>> static void test_tsc_deadline_timer(void)
>> {
>> if(enable_tsc_deadline_timer()) {
>> - printf("tsc deadline timer enabled\n");
>> + __test_tsc_deadline_timer();
>> } else {
>> - printf("tsc deadline timer not detected\n");
>> + report_skip("tsc deadline timer not detected\n");
>
> You probably don't want this '\n' anymore.

Thanks, I should have written that no care at all was given :(