Re: [PATCH kvm-unit-tests 4/6] run_tests: generalize check

Radim Krčmář
2015-12-15T13:05:51Z

2015-12-14 16:11-0600, Andrew Jones:
> On Mon, Dec 14, 2015 at 10:24:19PM +0100, Radim Krčmář wrote:
> > ---
>> diff --git a/run_tests.sh b/run_tests.sh
>> @@ -35,17 +35,10 @@ function run()
>> return
>> fi
>>
>> - # check a file for a particular value before running a test
>> - # the check line can contain multiple files to check separated by a space
>> - # but each check parameter needs to be of the form <path>=<value>
>> - for check_param in ${check[@]}; do
>> - path=${check_param%%=*}
>> - value=${check_param#*=}
>> - if [ "$path" ] && [ "$(cat $path)" != "$value" ]; then
>> - echo "skip $1 ($path not equal to $value)"
>> - return
>> - fi
>> - done
>> + eval $check || {
>> + echo "skip $1 (failed \$($check))"
>> + return
>> + }
>
> I think we should use "\e[33mSKIP\e[0m" for skip. Maybe we should create
> pass(),fail(),skip() functions in order to make sure all callers use the
> same prefix with the same color.

Sounds good.