From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests 2/6] x86/*: report skipped tests Date: Tue, 15 Dec 2015 13:58:41 +0100 Message-ID: <20151215125840.GC17283@potion.brq.redhat.com> References: <1450128261-21170-1-git-send-email-rkrcmar@redhat.com> <1450128261-21170-3-git-send-email-rkrcmar@redhat.com> <20151214220733.GD3633@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43429 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932283AbbLOM6o (ORCPT ); Tue, 15 Dec 2015 07:58:44 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 985D796A0 for ; Tue, 15 Dec 2015 12:58:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20151214220733.GD3633@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: 2015-12-14 16:07-0600, Andrew Jones: > On Mon, Dec 14, 2015 at 10:24:17PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99= wrote: >> No care to consistency or exhaustivity was given. >>=20 >> (svm-disabled test should be redone and it's weird that x86/hyperv_s= ynic >> is about the only one that does report_skip when unsupported.) >>=20 >> Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 >> --- >> diff --git a/x86/apic.c b/x86/apic.c >> @@ -55,9 +54,9 @@ static int enable_tsc_deadline_timer(void) >> static void test_tsc_deadline_timer(void) >> { >> if(enable_tsc_deadline_timer()) { >> - printf("tsc deadline timer enabled\n"); >> + __test_tsc_deadline_timer(); >> } else { >> - printf("tsc deadline timer not detected\n"); >> + report_skip("tsc deadline timer not detected\n"); >=20 > You probably don't want this '\n' anymore. Thanks, I should have written that no care at all was given :(