From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH kvm-unit-tests 3/6] x86/pmu: expect failure with
 nmi_watchdog
Date: Tue, 15 Dec 2015 14:01:01 +0100
Message-ID: <20151215130100.GB20852@potion.brq.redhat.com>
References: <1450128261-21170-1-git-send-email-rkrcmar@redhat.com>
 <1450128261-21170-4-git-send-email-rkrcmar@redhat.com>
 <20151214220550.GC3633@hawk.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:41104 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932733AbbLONBE (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 15 Dec 2015 08:01:04 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 5326019CBED
	for <kvm@vger.kernel.org>; Tue, 15 Dec 2015 13:01:04 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20151214220550.GC3633@hawk.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2015-12-14 16:05-0600, Andrew Jones:
> On Mon, Dec 14, 2015 at 10:24:18PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99=
 wrote:
>> diff --git a/x86/pmu.c b/x86/pmu.c
>> @@ -291,7 +292,7 @@ static void check_counters_many(void)
>>  		if (!verify_counter(&cnt[i]))
>>  			break;
>> =20
>> -	report("all counters", i =3D=3D n);
>> +	report_xfail("all counters", host_nmi_watchdog, i =3D=3D n);
>=20
> How about outputting "host_nmi_watchdog=3D%d" as well?

It's already implied in the output.  Prefix will be XPASS/XFAIL if
host_nmi_watchdog=3D1 and PASS/FAIL otherwise.

Should it still be explicitly printed?