From mboxrd@z Thu Jan  1 00:00:00 1970
From: Borislav Petkov <bp@suse.de>
Subject: Re: [Patch V2 1/2] x86,
 mce: Basic support to add LMCE support to QEMU
Date: Tue, 15 Dec 2015 14:04:46 +0100
Message-ID: <20151215130446.GE26000@pd.tnic>
References: <1449776482-26070-1-git-send-email-ashok.raj@intel.com>
	<20151214162356.GA5314@thinpad.lan.raisama.net>
	<20151214163738.GJ11630@pd.tnic>
	<20151214191145.GB18012@otc-brkl-03.jf.intel.com>
	<20151214223716.GK11630@pd.tnic>
	<20151215001726.GA22215@otc-brkl-03.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: qemu-devel@nongnu.org, Tony Luck <tony.luck@intel.com>,
	Eduardo Habkost <ehabkost@redhat.com>, kvm@vger.kernel.org,
	Gleb Natapov <gleb@kernel.org>, linux-kernel@vger.kernel.org,
	Gong Chen <gong.chen@intel.com>, Andi Kleen <andi.kleen@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>
To: "Raj, Ashok" <ashok.raj@intel.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
Content-Disposition: inline
In-Reply-To: <20151215001726.GA22215@otc-brkl-03.jf.intel.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On Mon, Dec 14, 2015 at 07:17:27PM -0500, Raj, Ashok wrote:
> I can see how this hurts.. since the poller isn't doing cpu model
> specific stuff..?

The poller sees mca_cfg.ser set on an AMD guest and then the whole
handling/decoding goes wrong.

> in the LMCE case, even if you advertise MCG_LMCE_P in MCG_CAP, the
> guest kernel wont call intel_init_lmce() only from mce_intel.c.. so
> the same problem won't happen.

You shouldn't advertise MCG_LMCE_P if the guest is not Intel. Those MCG
bits should be in the CPU model descriptor X86CPUDefinition.

--=20
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton=
, HRB 21284 (AG N=C3=BCrnberg)
--=20