From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests 0/6] Improve the output of test runners Date: Tue, 15 Dec 2015 14:10:58 +0100 Message-ID: <20151215131057.GC20852@potion.brq.redhat.com> References: <1450128261-21170-1-git-send-email-rkrcmar@redhat.com> <20151214222000.GG3633@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46659 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932176AbbLONLB (ORCPT ); Tue, 15 Dec 2015 08:11:01 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 557E368E24 for ; Tue, 15 Dec 2015 13:11:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20151214222000.GG3633@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: 2015-12-14 16:20-0600, Andrew Jones: > On Mon, Dec 14, 2015 at 10:24:15PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99= wrote: >> > skip vmx (0 tests, 0 unexpected failures) >> > PASS debug (7 tests, 0 unexpected failures) >> > qemu-kvm: Property '.hv-synic' not found >> > skip hyperv_synic (failed $(echo quit | $qemu -enable-kvm -cpu kvm= 64,hv_synic -device hyperv-testdev -monitor stdio > /dev/null)) >=20 > I'm not sure I like the (summary) addition. A summary of why we skip > would be useful, like the (i386 only) stuff, but otherwise it doesn't > seem necessary, and the "(failed $(echo quit | $qemu -enable-kvm -cpu > kvm64,hv_synic -device hyperv-testdev -monitor stdio > /dev/null))" > summary is a bit ugly, wrapping on many terminals. The summary should help to make callers more certain of what happened without spending time with tests.log. I'd like the summary more if we didn't print "0 unexpected failures" in passing/skipped cases, so maybe we can agree on that? I'll shorten the failed case. > Another comment that is series wide is that all these changes need to= be > tested with 'make standalone' (and many of your patches will require > changes to scripts/mkstandalone.sh, for which you will never forgive > me for having written :-) =46irst time I heard about it. :)