From: Andrew Jones <drjones@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH kvm-unit-tests 3/6] x86/pmu: expect failure with nmi_watchdog
Date: Tue, 15 Dec 2015 09:33:42 -0600 [thread overview]
Message-ID: <20151215153342.GA5373@hawk.localdomain> (raw)
In-Reply-To: <20151215130100.GB20852@potion.brq.redhat.com>
On Tue, Dec 15, 2015 at 02:01:01PM +0100, Radim Krčmář wrote:
> 2015-12-14 16:05-0600, Andrew Jones:
> > On Mon, Dec 14, 2015 at 10:24:18PM +0100, Radim Krčmář wrote:
> >> diff --git a/x86/pmu.c b/x86/pmu.c
> >> @@ -291,7 +292,7 @@ static void check_counters_many(void)
> >> if (!verify_counter(&cnt[i]))
> >> break;
> >>
> >> - report("all counters", i == n);
> >> + report_xfail("all counters", host_nmi_watchdog, i == n);
> >
> > How about outputting "host_nmi_watchdog=%d" as well?
>
> It's already implied in the output. Prefix will be XPASS/XFAIL if
> host_nmi_watchdog=1 and PASS/FAIL otherwise.
>
> Should it still be explicitly printed?
I think it could help interpret the results without needing to read
the code, but these types of tests generally require reading the
code...
drew
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-15 15:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 21:24 [PATCH kvm-unit-tests 0/6] Improve the output of test runners Radim Krčmář
2015-12-14 21:24 ` [PATCH kvm-unit-tests 1/6] lib/report: allow test skipping Radim Krčmář
2015-12-14 22:00 ` Andrew Jones
2015-12-14 22:12 ` Andrew Jones
2015-12-15 12:54 ` Radim Krčmář
2015-12-14 21:24 ` [PATCH kvm-unit-tests 2/6] x86/*: report skipped tests Radim Krčmář
2015-12-14 22:07 ` Andrew Jones
2015-12-15 12:58 ` Radim Krčmář
2015-12-14 21:24 ` [PATCH kvm-unit-tests 3/6] x86/pmu: expect failure with nmi_watchdog Radim Krčmář
2015-12-14 22:05 ` Andrew Jones
2015-12-15 13:01 ` Radim Krčmář
2015-12-15 15:33 ` Andrew Jones [this message]
2015-12-14 21:24 ` [PATCH kvm-unit-tests 4/6] run_tests: generalize check Radim Krčmář
2015-12-14 22:11 ` Andrew Jones
2015-12-15 13:05 ` Radim Krčmář
2015-12-14 21:24 ` [PATCH kvm-unit-tests 5/6] x86/hyperv_synic: check for support before testing Radim Krčmář
2015-12-14 21:24 ` [PATCH kvm-unit-tests 6/6] run_tests: print summary Radim Krčmář
2015-12-14 22:20 ` [PATCH kvm-unit-tests 0/6] Improve the output of test runners Andrew Jones
2015-12-15 13:10 ` Radim Krčmář
2015-12-15 10:19 ` Paolo Bonzini
2015-12-15 13:13 ` Radim Krčmář
2015-12-15 15:37 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215153342.GA5373@hawk.localdomain \
--to=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox