From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH] arm64: KVM: debug: Remove spurious inline attributes Date: Wed, 16 Dec 2015 21:45:51 +0100 Message-ID: <20151216204551.GG24889@cbox> References: <1450280963-19985-1-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, alex.bennee@linaro.org To: Marc Zyngier Return-path: Received: from mail-wm0-f43.google.com ([74.125.82.43]:33851 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755408AbbLPUpu (ORCPT ); Wed, 16 Dec 2015 15:45:50 -0500 Received: by mail-wm0-f43.google.com with SMTP id l126so57567752wml.1 for ; Wed, 16 Dec 2015 12:45:49 -0800 (PST) Content-Disposition: inline In-Reply-To: <1450280963-19985-1-git-send-email-marc.zyngier@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Dec 16, 2015 at 03:49:23PM +0000, Marc Zyngier wrote: > The debug trapping code is pretty heavy on the "inline" attribute, > but most functions are actually referenced in the sysreg tables, > making the inlining imposible. > > Removing the useless inline qualifier seems the right thing to do, > having verified that the output code is similar. To quote Rusty when he reviewd some of my first KVM patches: "I consider inline the register keyword of the 90s" You can take that as an: Acked-by: Christoffer Dall