Re: [PATCH kvm-unit-tests v2 00/12] Improve the output of test runners

Andrew Jones
2015-12-18T18:57:48Z

On Fri, Dec 18, 2015 at 01:38:31PM +0100, Radim Krčmář wrote:
> 2015-12-17 14:04-0600, Andrew Jones:
> > On Thu, Dec 17, 2015 at 06:53:31PM +0100, Radim Krčmář wrote:
> >> v1: http://www.spinics.net/lists/kvm/msg125202.html
> >>
> >> Drew brought up the existence of scripts/mkstandalone.sh, which
> >> significantly expanded v2 (and my set of curses) ...
> >> I didn't want to do the same twice, so first part of this series,
> >> [1-4/12], reuses run() from run_tests.sh and does some non-conservative
> >> changes to scripts/mkstandalone.sh. scripts/mkstandalone.sh is lacking
> >> behind run_tests.sh, but should be good enough to fulfill its purpose.
> >>
> >> The output of run_tests.sh has also changed a bit and now looks like
> >> this (you'll again need to imagine colours):
> >>
> >> > PASS apic (14 tests)
> >> > PASS ioapic (19 tests)
> >> > PASS smptest (1 tests)
> >> > PASS smptest3 (1 tests)
> >> > PASS vmexit_cpuid
> >> > PASS vmexit_vmcall
> >
> > Why do some tests, which have only 1 test, say (1 tests), but other
> > tests don't say anything?
>
> Some tests don't use lib/report, hence don't print "^SUMMARY:", so we
> don't really want to know what happens there.
>
> > Some nice improvements with this series. I'm not sure I like depending
> > on bash in standalone tests, but then that could just be cause I worked
> > pretty hard at avoiding the dependency, and thus I'll have to cry at the
> > loss of it...
>
> Knowing the percentage of KVM+QEMU installations without bash would
> help. I expect it to be very close to zero, which makes compassion hard
> to find ... sorry.

I'll look at the mkstandalone changes again. If taking a bash dependency
to maintain our sanity is necessary, then I won't fight it.

>
> > Please review the series I'll send in about 2 minutes, so we can discuss
> > how to integrate them.
>
> Will do, thanks. (Please excuse the delay.)
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html