Re: [PATCH kvm-unit-tests v2 01/12] run_tests: move run() to scripts/

Radim Krčmář
2015-12-18T10:42:43Z

2015-12-17 12:45-0600, Andrew Jones:
> On Thu, Dec 17, 2015 at 06:53:32PM +0100, Radim Krčmář wrote:
>> We'll be using it from scripts/mkstandalone later.
>>
>> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>> ---
>> v2: new
>>
>> run_tests.sh | 53 +----------------------------------------------------
>> scripts/run.bash | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
>
> Could probably just put run() in scripts/functions.bash

Definitely. The drawback is that for_each_unittest() and any future
helper would be pasted in each unit test, which would complicate
conversion back to shell and uselessly bloat tests. Even though I like
programming in shell far more than in C, I would not do it if we decide
to POSIX our standalone tests. (Bloating is not an issue for me.)