From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH kvm-unit-tests v2 09/12] x86/hyperv_synic: check for
 support before testing
Date: Fri, 18 Dec 2015 13:13:07 +0100
Message-ID: <20151218121307.GC21525@potion.brq.redhat.com>
References: <1450374823-7648-1-git-send-email-rkrcmar@redhat.com>
 <1450374823-7648-10-git-send-email-rkrcmar@redhat.com>
 <20151217194209.GG14168@hawk.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:35433 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752021AbbLRMNK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 18 Dec 2015 07:13:10 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id C1EE332D3B7
	for <kvm@vger.kernel.org>; Fri, 18 Dec 2015 12:13:10 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20151217194209.GG14168@hawk.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2015-12-17 13:42-0600, Andrew Jones:
> On Thu, Dec 17, 2015 at 06:53:40PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99=
 wrote:
>> It's not easy to distinguish successful unit-test from failed QEMU, =
so
>> we check for presence of the needed feature before hand.
>>=20
>> Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
>> ---
>>  v2: remove "> /dev/null" as check doesn't print the output anymore
>> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
>> @@ -182,3 +182,4 @@ arch =3D x86_64
>>  file =3D hyperv_synic.flat
>>  smp =3D 2
>>  extra_params =3D -cpu kvm64,hv_synic -device hyperv-testdev
>> +check =3D echo quit | $qemu -cpu kvm64,hv_synic -device hyperv-test=
dev -monitor stdio
>=20
> Let's make sure $QEMU=3D=3D$qemu in contexts where unittests.cfg is u=
sed, and
> then document (in the unittests.cfg header) that $QEMU may be used in=
 the
> check lines.

I'd just get rid of $qemu, we don't gain anything by having them both.
Documenting it is a good idea.