From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH kvm-unit-tests v2 00/12] Improve the output of test runners Date: Fri, 18 Dec 2015 13:38:31 +0100 Message-ID: <20151218123830.GF21525@potion.brq.redhat.com> References: <1450374823-7648-1-git-send-email-rkrcmar@redhat.com> <20151217200453.GK14168@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44232 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbbLRMie (ORCPT ); Fri, 18 Dec 2015 07:38:34 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 13709DCA23 for ; Fri, 18 Dec 2015 12:38:34 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20151217200453.GK14168@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: 2015-12-17 14:04-0600, Andrew Jones: > On Thu, Dec 17, 2015 at 06:53:31PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99= wrote: >> v1: http://www.spinics.net/lists/kvm/msg125202.html >>=20 >> Drew brought up the existence of scripts/mkstandalone.sh, which >> significantly expanded v2 (and my set of curses) ... >> I didn't want to do the same twice, so first part of this series, >> [1-4/12], reuses run() from run_tests.sh and does some non-conservat= ive >> changes to scripts/mkstandalone.sh. scripts/mkstandalone.sh is lack= ing >> behind run_tests.sh, but should be good enough to fulfill its purpos= e. >>=20 >> The output of run_tests.sh has also changed a bit and now looks like >> this (you'll again need to imagine colours): >>=20 >> > PASS apic (14 tests) >> > PASS ioapic (19 tests) >> > PASS smptest (1 tests) >> > PASS smptest3 (1 tests) >> > PASS vmexit_cpuid >> > PASS vmexit_vmcall >=20 > Why do some tests, which have only 1 test, say (1 tests), but other > tests don't say anything? Some tests don't use lib/report, hence don't print "^SUMMARY:", so we don't really want to know what happens there. > Some nice improvements with this series. I'm not sure I like dependin= g > on bash in standalone tests, but then that could just be cause I work= ed > pretty hard at avoiding the dependency, and thus I'll have to cry at = the > loss of it... Knowing the percentage of KVM+QEMU installations without bash would help. I expect it to be very close to zero, which makes compassion har= d to find ... sorry. > Please review the series I'll send in about 2 minutes, so we can disc= uss > how to integrate them. Will do, thanks. (Please excuse the delay.)